Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 892382 - [PATCH] js miscompiled on armv5
Summary: [PATCH] js miscompiled on armv5
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: js
Version: 18
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Peter Robinson
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: ARMTracker F18ArmBlocker
TreeView+ depends on / blocked
 
Reported: 2013-01-07 00:37 UTC by Lubomir Rintel
Modified: 2013-03-16 08:17 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-02-01 17:19:15 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
[PATCH] Fix compiler flags on ARM (4.89 KB, application/octet-stream)
2013-01-07 00:37 UTC, Lubomir Rintel 		no flags Details
View All

Description Lubomir Rintel 2013-01-07 00:37:02 UTC 
Created attachment 673567 [details]
[PATCH] Fix compiler flags on ARM

Description of problem:

js build hardcodes -march=armv7-a, which is wrong on non-v7 ARms.

Version-Release number of selected component (if applicable):

js-1.8.5-11.fc19.armv5tel

How reproducible:

On a v5 arm:
[lkundrak@megalodon ~]$ lscpu
Architecture:          armv5tel
Byte Order:            Little Endian
CPU(s):                1
On-line CPU(s) list:   0
Thread(s) per core:    1
Core(s) per socket:    1
Socket(s):             1
[lkundrak@megalodon ~]$ uname -a
Linux megalodon 3.7.0-6.fc19.armv5tel.kirkwood #1 Mon Dec 24 10:36:18 EST 2012 armv5tel armv5tel armv5tel GNU/Linux
[lkundrak@megalodon ~]$

Steps to Reproduce:
1. Run js
  
Actual results:

[root@megalodon lkundrak]# /usr/lib/polkit-1/polkitd
Successfully changed to user polkitd
Illegal instruction
[root@megalodon lkundrak]# exit
[lkundrak@megalodon ~]$ js
Illegal instruction
[lkundrak@megalodon ~]$ 

Expected results:

[root@megalodon lkundrak]# /usr/lib/polkit-1/polkitd
Successfully changed to user polkitd
00:31:53.348: Loading rules from directory /etc/polkit-1/rules.d
00:31:53.352: Loading rules from directory /usr/share/polkit-1/rules.d
^C
[root@megalodon lkundrak]# exit
[lkundrak@megalodon ~]$ js
js> trolol
typein:1: ReferenceError: trolol is not defined
js> 

Additional info:

Fix for the issue is attached.
Comment 1 Peter Robinson 2013-01-07 09:06:50 UTC 
Actually we shouldn't have " -mthumb $MOZ_ARM_VFP_FLAGS" either as they're set by the rpm cflags to our required settings as well. I'll push a modified version of the patch today.
Comment 2 Dennis Gilmore 2013-01-23 14:39:12 UTC 
I had already applied basicaly the same thing,  Peter is is correct, the build does not use -mthumb  that part of the files is chosen when you enable thumb optimisations as a build flag
Comment 3 Fedora Update System 2013-01-23 18:42:24 UTC 
js-1.8.5-12.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/js-1.8.5-12.fc18
Comment 4 Fedora Update System 2013-01-24 22:40:58 UTC 
Package js-1.8.5-12.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing js-1.8.5-12.fc18'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-1446/js-1.8.5-12.fc18
then log in and leave karma (feedback).
Comment 5 Fedora Update System 2013-02-01 17:19:18 UTC 
js-1.8.5-12.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 6 Pavel Alexeev 2013-03-16 08:17:53 UTC 
Thank you, guys.
Note You need to log in before you can comment on or make changes to this bug.