Add npm(bindings) to BuildRequires.

Spec URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/nodejs-libxmljs.spec
SRPM URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/SRPMS/nodejs-libxmljs-0.7.0-2.fc18.src.rpm

Package Review
==============

Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package installs properly.

Require bindings 1.0.0 but we have 1.1.0 now.

- Permissions on files are set properly.

nodejs-libxmljs.x86_64: E: non-standard-executable-perm /usr/lib/node_modules/libxmljs/build/xmljs.node 0775L

- Requires correct, justified where necessary.

The explicit requires on v8 should not be needed any more.

- Latest version is packaged.

Upstream released 0.7.1 a few days ago.


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Unknown or generated". 1 files have unknown license. Detailed output of
     licensecheck in /home/tom/910132-nodejs-libxmljs/licensecheck.txt
[x]: Package consistently uses macro is (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Large documentation must go in a -doc subpackage.
     Note: Documentation size is 40960 bytes in 15 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Fully versioned dependency in subpackages, if present.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[!]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define.

===== EXTRA items =====

Generic:
[!]: Rpmlint is run on all installed packages.
     Note: Mock build failed
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Spec file according to URL is the same as in SRPM.


Installation errors
-------------------
INFO: mock.py version 1.1.29 starting...
Start: init plugins
INFO: selinux disabled
Finish: init plugins
Start: run
Mock Version: 1.1.29
INFO: Mock Version: 1.1.29
Start: lock buildroot
INFO: installing package(s): /home/tom/910132-nodejs-libxmljs/results/nodejs-libxmljs-0.7.0-2.fc20.x86_64.rpm
ERROR: Command failed: 
 # ['/usr/bin/yum', '--installroot', '/var/lib/mock/compton-rawhide-x86_64/root/', 'install', '/home/tom/910132-nodejs-libxmljs/results/nodejs-libxmljs-0.7.0-2.fc20.x86_64.rpm']
Error: Package: nodejs-libxmljs-0.7.0-2.fc20.x86_64 (/nodejs-libxmljs-0.7.0-2.fc20.x86_64)
           Requires: npm(bindings) = 1.0.0
           Installed: nodejs-bindings-1.1.0-1.fc20.noarch (@fedora)
               npm(bindings) = 1.1.0
 You could try using --skip-broken to work around the problem
 You could try running: rpm -Va --nofiles --nodigest



Rpmlint
-------
Checking: nodejs-libxmljs-0.7.0-2.fc20.x86_64.rpm
nodejs-libxmljs.x86_64: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-libxmljs.x86_64: W: spelling-error Summary(en_US) libxml -> Librium
nodejs-libxmljs.x86_64: W: spelling-error Summary(en_US) javascript -> java script, java-script, JavaScript
nodejs-libxmljs.x86_64: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-libxmljs.x86_64: W: spelling-error %description -l en_US libxml -> Librium
nodejs-libxmljs.x86_64: W: spelling-error %description -l en_US javascript -> java script, java-script, JavaScript
nodejs-libxmljs.x86_64: W: dangling-symlink /usr/lib/node_modules/libxmljs/node_modules/bindings /usr/lib/node_modules/bindings
nodejs-libxmljs.x86_64: E: non-standard-executable-perm /usr/lib/node_modules/libxmljs/build/xmljs.node 0775L
1 packages and 0 specfiles checked; 1 errors, 7 warnings.




Requires
--------
nodejs-libxmljs (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libdl.so.2()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libpthread.so.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libxml2.so.2()(64bit)
    libxml2.so.2(LIBXML2_2.4.30)(64bit)
    libxml2.so.2(LIBXML2_2.5.8)(64bit)
    libxml2.so.2(LIBXML2_2.6.0)(64bit)
    libxml2.so.2(LIBXML2_2.6.2)(64bit)
    libxml2.so.2(LIBXML2_2.6.23)(64bit)
    libxml2.so.2(LIBXML2_2.6.8)(64bit)
    libz.so.1()(64bit)
    nodejs(abi)
    nodejs(engine)
    nodejs(v8-abi)
    npm(bindings)
    rtld(GNU_HASH)
    v8



Provides
--------
nodejs-libxmljs:
    nodejs-libxmljs
    nodejs-libxmljs(x86-64)
    npm(libxmljs)
    xmljs.node()(64bit)



MD5-sum check
-------------
http://registry.npmjs.org/libxmljs/-/libxmljs-0.7.0.tgz :
  CHECKSUM(SHA256) this package     : 22fd478c6a4ae3717a6540dcd0b10d3a9d958c1539b2425ccd675369ecbe8204
  CHECKSUM(SHA256) upstream package : 22fd478c6a4ae3717a6540dcd0b10d3a9d958c1539b2425ccd675369ecbe8204


Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29
Buildroot used: compton-rawhide-x86_64
Command line :/usr/bin/fedora-review -m compton-rawhide-x86_64 -b 910132

> - Package installs properly.
> 
> Require bindings 1.0.0 but we have 1.1.0 now.

Fixed.


> - Permissions on files are set properly.
> 
> nodejs-libxmljs.x86_64: E: non-standard-executable-perm /usr/lib/node_modules/libxmljs/build/xmljs.node 0775L

Fixed.


> - Requires correct, justified where necessary.
> 
> The explicit requires on v8 should not be needed any more.

Done.


> - Latest version is packaged.
> 
> Upstream released 0.7.1 a few days ago.

Updated.


Spec URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/nodejs-libxmljs.spec
SRPM URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/SRPMS/nodejs-libxmljs-0.7.1-1.fc18.src.rpm

Looks good now. Package approved.

New Package SCM Request
=======================
Package Name: nodejs-libxmljs
Short Description: Node.js module that provides libxml bindings for the v8 JavaScript engine
Owners: jamielinux
Branches: f18 f19 el6
InitialCC:

Git done (by process-git-requests).

nodejs-libxmljs-0.7.1-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/nodejs-libxmljs-0.7.1-1.fc18

nodejs-libxmljs-0.7.1-1.fc18 has been pushed to the Fedora 18 stable repository.