Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 910508 (kjumpingcube) - Review Request: kjumpingcube - Territory capture game
Summary: Review Request: kjumpingcube - Territory capture game
Keywords:
Status: CLOSED RAWHIDE
Alias: kjumpingcube
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: nucleo
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: libkdegames
Blocks: kde-reviews kde-4.10
TreeView+ depends on / blocked
 
Reported: 2013-02-12 18:36 UTC by Rex Dieter
Modified: 2013-02-16 19:06 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-02-16 19:06:18 UTC
Type: ---
Embargoed:
alekcejk: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Rex Dieter 2013-02-12 18:36:27 UTC
Spec URL: http://rdieter.fedorapeople.org/rpms/kdegames/kjumpingcube.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/kdegames/kjumpingcube-4.10.0-1.fc18.src.rpm
Description: A simple tactical game
Fedora Account System Username: rdieter

Comment 1 nucleo 2013-02-14 22:03:23 UTC
Summary: Territory Capture Game
(from .desktop file)

Code under GPLv2+ license, doc under GFDL, license tag must be:

License: GPLv2+ and GFDL

COPYING.DOC must be added in %doc
Add notices for parts under different licenses.

Also there are useful files 
%doc AUTHORS README ChangeLog


Detailed %description from documentation:

KJumpingCube is a simple tactical game. You can play it against the computer
or a friend. The playing area consists of squares containing points. When the
game starts each square has only one point, and no owner. Players move by
clicking on either a vacant square or one of their own squares, thus
increasing the square’s point value by one. When a square’s value reaches
a maximum, the excess points are distributed around the neighboring squares,
taking over ownership of them. The winner is the player who ends up owning
all the squares.

rpmlint output:
$ rpmlint kjumpingcube-4.10.0-1.fc18.i686.rpm kjumpingcube-debuginfo-4.10.0-1.fc18.i686.rpm kjumpingcube-4.10.0-1.fc18.src.rpm kjumpingcube.spec 
kjumpingcube.i686: W: no-manual-page-for-binary kjumpingcube
kjumpingcube.src:66: W: macro-in-comment %{name}
kjumpingcube.src:70: W: macro-in-comment %{name}
kjumpingcube.spec:66: W: macro-in-comment %{name}
kjumpingcube.spec:70: W: macro-in-comment %{name}
3 packages and 1 specfiles checked; 0 errors, 5 warnings.

Commented lines should be removed (#doc README corrected).

Comment 2 nucleo 2013-02-15 00:27:07 UTC
or even better such summary:
Summary: Territory capture game

Comment 3 Rex Dieter 2013-02-15 13:42:09 UTC
Spec URL: http://rdieter.fedorapeople.org/rpms/kdegames/kjumpingcube.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/kdegames/kjumpingcube-4.10.0-2.fc18.src.rpm

%changelog
* Fri Feb 15 2013 Rex Dieter <rdieter> 4.10.0-2
- update license, description/summary

Comment 4 nucleo 2013-02-16 18:22:27 UTC
MUST Items:
+ rpmlint output
  $ rpmlint kjumpingcube-4.10.0-1.fc18.i686.rpm kjumpingcube-debuginfo-4.10.0-1.fc18.i686.rpm kjumpingcube-4.10.0-2.fc18.src.rpm kjumpingcube.spec 
    kjumpingcube.i686: W: no-manual-page-for-binary kjumpingcube
    3 packages and 1 specfiles checked; 0 errors, 1 warnings.
+ named and versioned according to the Package Naming Guidelines.
  Package name match the upstream tarball name kjumpingcube-4.10.0.tar.xz
+ spec file name kjumpingcube.spec matches base package name
+ complies with all the legal guidelines:
  + License: GPLv2+ and GFDL, matches actual license
  + No known patent problems
  + No emulator, no firmware, no binary-only or prebuilt components
+ COPYING (GNU GENERAL PUBLIC LICENSE Version 2), COPYING.DOC (GNU Free Documentation License Version 1.2) packaged as %doc
+ source matches upstream:
  MD5: 3e903cfebc6c44a12a1540d4898d681e  kjumpingcube-4.10.0.tar.xz
  SHA1: 1f42e117175b75ae994ea5141ec52a4f2516bdce  kjumpingcube-4.10.0.tar.xz
  SHA256: 4a8961eb7a9dc432ff854e825e1681270683f0b8d4eb7f97de50da7ba3e88738  kjumpingcube-4.10.0.tar.xz
+ builds on at least one arch
  build from mock is in F18 kde-unstable repo
+ no known non-working arches, so no ExcludeArch needed
+ no missing BuildRequires (builds in mock)
+ locales are handled properly by using %find_lang %{name} --with-kde macro
+ ldconfig call not needed (no shared libraries)
+ no duplicated system libraries
+ package not relocatable (no Prefix tag)
+ directory ownership correct (doesn't own directories owned by another package, owns all package-specific directories %{_kde4_appsdir}/%{name}/)
+ no duplicate files in %files
+ permissions correct, %defattr(-,root,root,-) not needed now, executables have executable permissions
+ macros used where possible (%{name}, %{version}, %{buildroot}, %{_target_platform}, %{cmake_kde4}, %{_kde4_datadir}, %{_kde4_bindir}, %{_kde4_iconsdir},%{_kde4_appsdir}, %{_kde4_configdir} )
+ non-code content: only permitted content, pics under license that matches the code
+ no large documentation files, so no -doc package needed
+ no %doc files required at runtime
+ no header files, no -devel package needed
+ no static libraries, so no -static package needed
+ no devel symlinks which would need to be in a -devel subpackage
+ devel packages must require the base package (no -devel package)
+ no .la files
+ kjumpingcube.desktop file for the GUI app kjumpingcube present
+ desktop-file-validate is used in %check and the kjumpingcube.desktop file passes validation
+ all filenames are valid UTF-8
+ other packaging guidelines:
  + complies with the Filesystem Hierarchy Standard (all files in  %{_kde4_datadir}, %{_kde4_bindir}, %{_kde4_iconsdir},%{_kde4_appsdir}, %{_kde4_configdir})
  + proper changelog, tags, BuildRequires, Summary, Description (got from kjumpingcube's documentation)
  + no non-UTF-8 characters
  + all relevant documentation included as %doc (COPYING, COPYING.DOC, AUTHORS, README)
  + RPM_OPT_FLAGS are used in %{cmake_kde4} macro
  + debuginfo package is valid (contains stripped symbols from ELF binary and source code related to it)
  + no rpaths (no check-rpaths error)
  + no configuration files, so %config guideline doesn't apply
  + no init scripts, so init script guideline doesn't apply
  + timestamps are preserved
  + %{?_smp_mflags} used
  + not a web application, so web application guideline doesn't apply
  + no conflicts (kdegames-4.10.0 is metapackage now which not includes apps)

SHOULD Items:
+ license already included upstream
+ no translations for description and summary provided by upstream
+ package builds in mock (built for kde-unstable)
- successfully tested the package functionality (no testing yet)
+ scriptlets are sane (updating icon chache in %post, %postun, %posttrans)
+ subpackages other than devel should require the base package using a fully versioned dependency (no subpackages)
+ no .pc files, so "placement of .pc files" is irrelevant
+ no file dependencies
- package should contain man pages for binaries/scripts

APPROVED

Comment 5 Rex Dieter 2013-02-16 18:25:40 UTC
New Package SCM Request
=======================
Package Name: kjumpingcube
Short Description: Territory capture game
Owners: than rdieter jreznik kkofler ltinkl rnovacek
Branches: f17 f18
InitialCC:

Comment 6 Gwyn Ciesla 2013-02-16 18:49:44 UTC
Git done (by process-git-requests).

Comment 7 Rex Dieter 2013-02-16 19:06:18 UTC
imported


Note You need to log in before you can comment on or make changes to this bug.