Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 910520 (kollision) - Review Request: kollision - A simple ball dodging game
Summary: Review Request: kollision - A simple ball dodging game
Keywords:
Status: CLOSED RAWHIDE
Alias: kollision
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: nucleo
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: libkdegames
Blocks: kde-reviews kde-4.10
TreeView+ depends on / blocked
 
Reported: 2013-02-12 19:03 UTC by Rex Dieter
Modified: 2013-02-16 19:15 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-02-16 19:15:52 UTC
Type: ---
Embargoed:
alekcejk: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Rex Dieter 2013-02-12 19:03:43 UTC
Spec URL: http://rdieter.fedorapeople.org/rpms/kdegames/kollision.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/kdegames/kollision-4.10.0-1.fc18.src.rpm
Description: A simple ball dodging game
Fedora Account System Username: rdieter

Comment 1 nucleo 2013-02-15 01:10:06 UTC
Code under GPLv2+ license, doc under GFDL, license tag must be:

License: GPLv2+ and GFDL

COPYING.DOC must be added in %doc
Add notices for parts under different licenses.


rpmlint output:
$ rpmlint kollision-4.10.0-1.fc18.i686.rpm kollision-debuginfo-4.10.0-1.fc18.i686.rpm kollision-4.10.0-1.fc18.src.rpm kollision.spec 
kollision.i686: W: no-manual-page-for-binary kollision
kollision.src:71: W: macro-in-comment %{name}
kollision.src:72: W: macro-in-comment %{name}
kollision.src:76: W: macro-in-comment %{name}
kollision.spec:71: W: macro-in-comment %{name}
kollision.spec:72: W: macro-in-comment %{name}
kollision.spec:76: W: macro-in-comment %{name}
3 packages and 1 specfiles checked; 0 errors, 7 warnings.

All commented lines should be removed.



Unfortunately no useful description provided in documentation. 
There is Objective: 
Let the blue ball move in the field without touching the red balls.

So maybe  %description can be for example:

Kollision is a simple ball dodging game. Let the blue ball 
move in the field without touching the red balls.

Comment 2 Rex Dieter 2013-02-15 14:46:54 UTC
Spec URL: http://rdieter.fedorapeople.org/rpms/kdegames/kollision.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/kdegames/kollision-4.10.0-2.fc18.src.rpm

%changelog
* Fri Feb 15 2013 Rex Dieter <rdieter> 4.10.0-2
- update license, description

Comment 3 nucleo 2013-02-16 18:43:53 UTC
MUST Items:
+ rpmlint output
  $ rpmlint kollision-4.10.0-1.fc18.i686.rpm kollision-debuginfo-4.10.0-1.fc18.i686.rpm kollision-4.10.0-2.fc18.src.rpm kollision.spec 
    kollision.i686: W: no-manual-page-for-binary kollision
    3 packages and 1 specfiles checked; 0 errors, 1 warnings.
+ named and versioned according to the Package Naming Guidelines.
  Package name match the upstream tarball name kollision-4.10.0.tar.xz
+ spec file name kollision.spec matches base package name
+ complies with all the legal guidelines:
  + License: GPLv2+ and GFDL, matches actual license
  + No known patent problems
  + No emulator, no firmware, no binary-only or prebuilt components
+ COPYING (GNU GENERAL PUBLIC LICENSE Version 2), COPYING.DOC (GNU Free Documentation License Version 1.2) packaged as %doc
+ source matches upstream:
  MD5: 32241c3d1cbc6a70c4eb5f5e8fbdd05c  kollision-4.10.0.tar.xz
  SHA1: edaa3f7bc9b15982e2aae6b7e97ce05dcf70fea8  kollision-4.10.0.tar.xz
  SHA256: 6e690e695023e7fa1ab512a89a2d827d204fda58bf6798a312bff64c15ae9849  kollision-4.10.0.tar.xz
+ builds on at least one arch
  build from mock is in F18 kde-unstable repo
+ no known non-working arches, so no ExcludeArch needed
+ no missing BuildRequires (builds in mock)
+ locales are handled properly by using %find_lang %{name} --with-kde macro
+ ldconfig call not needed (no shared libraries)
+ no duplicated system libraries
+ package not relocatable (no Prefix tag)
+ directory ownership correct (doesn't own directories owned by another package, owns all package-specific directories %{_kde4_appsdir}/%{name}/)
+ no duplicate files in %files
+ permissions correct, %defattr(-,root,root,-) not needed now, executables have executable permissions
+ macros used where possible (%{name}, %{version}, %{buildroot}, %{_target_platform}, %{cmake_kde4}, %{_kde4_datadir}, %{_kde4_bindir}, %{_kde4_iconsdir},%{_kde4_appsdir} )
+ non-code content: only permitted content, pictures and sounds under license that matches the code, docs under GFDL
+ no large documentation files, so no -doc package needed
+ no %doc files required at runtime
+ no header files, no -devel package needed
+ no static libraries, so no -static package needed
+ no devel symlinks which would need to be in a -devel subpackage
+ devel packages must require the base package (no -devel package)
+ no .la files
+ kollision.desktop file for the GUI app kollision present
+ desktop-file-validate is used in %check and the kollision.desktop file passes validation
+ all filenames are valid UTF-8
+ other packaging guidelines:
  + complies with the Filesystem Hierarchy Standard (all files in  %{_kde4_datadir}, %{_kde4_bindir}, %{_kde4_iconsdir},%{_kde4_appsdir})
  + proper changelog, tags, BuildRequires, Summary, Description (got from kollision's documentation)
  + no non-UTF-8 characters
  + all relevant documentation included as %doc (COPYING, COPYING.DOC)
  + RPM_OPT_FLAGS are used in %{cmake_kde4} macro
  + debuginfo package is valid (contains stripped symbols from ELF binary and source code related to it)
  + no rpaths (no check-rpaths error)
  + no configuration files, so %config guideline doesn't apply
  + no init scripts, so init script guideline doesn't apply
  + timestamps are preserved
  + %{?_smp_mflags} used
  + not a web application, so web application guideline doesn't apply
  + no conflicts (kdegames-4.10.0 is metapackage now which not includes apps)

SHOULD Items:
+ license already included upstream
+ no translations for description and summary provided by upstream
+ package builds in mock (built for kde-unstable)
- successfully tested the package functionality (no testing yet)
+ scriptlets are sane (updating hicolor and oxygen icon chache in %post, %postun, %posttrans)
+ subpackages other than devel should require the base package using a fully versioned dependency (no subpackages)
+ no .pc files, so "placement of .pc files" is irrelevant
+ no file dependencies
- package should contain man pages for binaries/scripts

APPROVED

Comment 4 Rex Dieter 2013-02-16 18:47:47 UTC
New Package SCM Request
=======================
Package Name: kollision
Short Description: A simple ball dodging game
Owners: than rdieter jreznik kkofler ltinkl rnovacek
Branches: f17 f18
InitialCC:

Comment 5 Gwyn Ciesla 2013-02-16 19:06:03 UTC
Git done (by process-git-requests).

Comment 6 Rex Dieter 2013-02-16 19:15:52 UTC
imported


Note You need to log in before you can comment on or make changes to this bug.