Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 911894 (kshutdown2) - Review Request: kshutdown2 - advanced shut down utility for KDE 4
Summary: Review Request: kshutdown2 - advanced shut down utility for KDE 4
Keywords:
Status: CLOSED NOTABUG
Alias: kshutdown2
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2013-02-16 14:10 UTC by Jan Grulich
Modified: 2013-02-17 14:24 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-02-17 14:24:02 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Jan Grulich 2013-02-16 14:10:22 UTC 
Spec URL: http://jgrulich.fedorapeople.org/kshutdown2.spec
SRPM URL: http://jgrulich.fedorapeople.org/kshutdown2-3.0.1beta6-1.fc18.src.rpm
Description: kshutdown is an advanced shut down utility for KDE 4.
Fedora Account System Username:jgrulich

Successful build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4998555
Comment 1 Kevin Kofler 2013-02-17 12:30:37 UTC 
Not a full review, but some remarks:
* Why call this package "kshutdown2" rather than just "kshutdown"? Especially considering that it's actually version 3 and I see nothing upstream using the -2 suffix.
* Version 3.0.1beta6 is not valid according to the naming/versioning guidelines:
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages
* At least the long %description should explain what this tool does that the builtin KDE Plasma shutdown dialog doesn't do. For example, the screenshot shows timed shutdowns.
Comment 2 Jan Grulich 2013-02-17 13:18:21 UTC 
1) Because we already have kshutdown package which is for KDE 3. So I decided to make it as a new package instead of updating the old package and it is called kshutdown2 because the branch in svn repository is called kshutdown2.

Update:
Spec URL: http://jgrulich.fedorapeople.org/kshutdown2.spec
SRPM URL: http://jgrulich.fedorapeople.org/kshutdown2-3.0-2.beta6.fc18.fc18.src.rpm
Comment 3 Jan Grulich 2013-02-17 13:20:49 UTC 
Damn, wrong link

Update:
Spec URL: http://jgrulich.fedorapeople.org/kshutdown2.spec
SRPM URL: http://jgrulich.fedorapeople.org/kshutdown2-3.0-2.beta6.fc18.src.rpm
Comment 4 Kevin Kofler 2013-02-17 14:18:52 UTC 
You're going to Obsolete the old KDE 3 version anyway, so you should claim ownership of the old package and update that.

And Release: 2.beta6 is still not compliant to the guidelines, it should be 0.1.beta6, 0.2.beta6, 0.3.beta6 etc. The idea is that it must be smaller than 1, which is used by the first package of the actual 3.0 release.
Comment 5 Kevin Kofler 2013-02-17 14:24:02 UTC 
Now if Chitlesh is not responding to your ACL requests (nor willing to upgrade the package himself), you should start the nonresponsive maintainer procedure:
https://fedoraproject.org/wiki/Policy_for_nonresponsive_package_maintainers

Obsoleting a package without that package's maintainer's consent is not acceptable anyway.
Note You need to log in before you can comment on or make changes to this bug.