Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 922882 - [RFE] request for pre_product_id_remove_hook and post_product_id_remove_hook
Summary: [RFE] request for pre_product_id_remove_hook and post_product_id_remove_hook
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: subscription-manager
Version: 7.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: 7.1
Assignee: candlepin-bugs
QA Contact: John Sefler
URL:
Whiteboard:
Depends On:
Blocks: rhsm-rhel72
TreeView+ depends on / blocked
 
Reported: 2013-03-18 17:44 UTC by John Sefler
Modified: 2015-05-08 18:52 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-05-08 18:52:23 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)

Description John Sefler 2013-03-18 17:44:48 UTC 
Description of problem:
subscription-manager plugins currently has slots for a pre/post_product_id_install_hooks  It is being passed a conduit with a product_list.  A couple of requests:


1. These install hooks are also being called during a yum remove transaction with an empty product_list.  If the product_list is empty, there is no reason to call the pre/post_product_id_install_hooks.  Don't do it.

2. In case that product are about to be removed, we should build new slots for pre/post_product_id_revove and call the pre/post_product_id_revove_hooks when the removal list is non-empty.

3. All of the calls to pre/post_product_id_*_hooks should provided a mechanism for the plugins to alter the product_list.  It is conceivable that the plugin should be empowered to overrule/augment the install or removal of a product cert.

4. Currently the product_list is the only interesting data passed to the hooks.  Including the repo from which a product id cert is being installed may also be useful.  There may be other interesting values too. 


Version-Release number of selected component (if applicable):
[root@rhsm-accept-rhel6 ~]# rpm -q subscription-manager
subscription-manager-1.8.4-1.git.31.00b0b78.el6.x86_64
Comment 1 RHEL Program Management 2013-04-09 20:17:17 UTC 
This request was evaluated by Red Hat Product Management for inclusion
in a Red Hat Enterprise Linux release.  Product Management has
requested further review of this request by Red Hat Engineering, for
potential inclusion in a Red Hat Enterprise Linux release for currently
deployed products.  This request is not yet committed for inclusion in
a release.
Comment 3 Adrian Likins 2013-06-27 14:50:41 UTC 
(In reply to John Sefler from comment #0)
> Description of problem:
> subscription-manager plugins currently has slots for a
> pre/post_product_id_install_hooks  It is being passed a conduit with a
> product_list.  A couple of requests:
> 
> 
> 1. These install hooks are also being called during a yum remove transaction
> with an empty product_list.  If the product_list is empty, there is no
> reason to call the pre/post_product_id_install_hooks.  Don't do it.

I think there may be some utility to this, especialy if #3/#4 are added. That would allow a plugin to install productids, that would not be selected for install otherwise (maybe a product that has no rpms in it's repo, for example).
Comment 5 Bryan Kearney 2014-07-30 19:21:03 UTC 
Acking 7.1
Comment 6 John Sefler 2014-10-28 17:55:17 UTC 
This feature request was not implemented and delivered to QE by the rhel-7.1.0 Dev Freeze date of 10/27/2014.  Deferring for consideration in next release.
Note You need to log in before you can comment on or make changes to this bug.