This package built on koji:  http://koji.fedoraproject.org/koji/taskinfo?taskID=5159537

*** Bug 648248 has been marked as a duplicate of this bug. ***

Updated to latest release and approved haskell guidelines.

Spec: http://petersen.fedorapeople.org/reviews/ghc-crypto-api/1/ghc-crypto-api.spec
SRPM: http://petersen.fedorapeople.org/reviews/ghc-crypto-api/1/ghc-crypto-api-0.12.2.1-1.fc18.src.rpm

Sorry correct urls are:

Spec: http://petersen.fedorapeople.org/reviews/ghc-crypto-api/ghc-crypto-api.spec
SRPM: http://petersen.fedorapeople.org/reviews/ghc-crypto-api/ghc-crypto-api-0.12.2.1-1.fc18.src.rpm

Built in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5478776

and f18 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5479066

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

C/C++:
[-]: Package does not contain kernel modules.
[-]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[-]: Fully versioned dependency in subpackages, if present.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ghc-crypto-
     api-devel
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Unknown or generated". 2 files have unknown license. Detailed output of
     licensecheck in /home/petersen/pkgreview/ghc-crypto-api/1/925987-ghc-
     crypto-api/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[-]: Package consistently uses macro is (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Scriptlets must be sane, if used.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define.

===== EXTRA items =====

Generic:
[-]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
     Note: Arch-ed rpms have a total of 2037760 bytes in /usr/share 2027520
     ghc-crypto-api-devel-0.12.2.1-1.fc20.x86_64.rpm 10240 ghc-crypto-
     api-0.12.2.1-1.fc20.x86_64.rpm
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

Rpmlint
-------
Checking: ghc-crypto-api-0.12.2.1-1.fc20.x86_64.rpm
          ghc-crypto-api-devel-0.12.2.1-1.fc20.x86_64.rpm
ghc-crypto-api.x86_64: W: spelling-error Summary(en_US) cryptographic -> cryptography, cryptographer, crystallographic
ghc-crypto-api.x86_64: W: spelling-error %description -l en_US cryptographic -> cryptography, cryptographer, crystallographic
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Rpmlint (installed packages)
----------------------------
# rpmlint ghc-crypto-api-devel ghc-crypto-api
ghc-crypto-api.x86_64: W: spelling-error Summary(en_US) cryptographic -> cryptography, cryptographer, crystallographic
ghc-crypto-api.x86_64: W: spelling-error %description -l en_US cryptographic -> cryptography, cryptographer, crystallographic
2 packages and 0 specfiles checked; 0 errors, 2 warnings.
# echo 'rpmlint-done:'

Requires
--------
ghc-crypto-api-devel (rpmlib, GLIBC filtered):
    /bin/sh
    ghc(crypto-api-0.12.2.1-321595f9c4d0101062826a29c2727ab1)
    ghc-compiler
    ghc-crypto-api
    ghc-devel(base-4.5.1.0-6e4c9bdc36eeb9121f27ccbbcb62e3f3)
    ghc-devel(bytestring-0.9.2.1-503e91bb155301fdb1956cb5c26ce6e9)
    ghc-devel(cereal-0.3.5.2-807bd944bfc86ac5df2f667be96ad9f0)
    ghc-devel(entropy-0.2.1-b341b337b9c23bd4c007232016870c95)
    ghc-devel(tagged-0.4.4-886769b727dcf06f0418d254f5119104)
    ghc-devel(transformers-0.3.0.0-8e66ecc7d4dae2b07b2b5406908c70e4)

ghc-crypto-api (rpmlib, GLIBC filtered):
    ghc(base-4.5.1.0-6e4c9bdc36eeb9121f27ccbbcb62e3f3)
    ghc(bytestring-0.9.2.1-503e91bb155301fdb1956cb5c26ce6e9)
    ghc(cereal-0.3.5.2-807bd944bfc86ac5df2f667be96ad9f0)
    ghc(entropy-0.2.1-b341b337b9c23bd4c007232016870c95)
    ghc(tagged-0.4.4-886769b727dcf06f0418d254f5119104)
    ghc(transformers-0.3.0.0-8e66ecc7d4dae2b07b2b5406908c70e4)
    libHSarray-0.4.0.0-ghc7.4.2.so()(64bit)
    libHSbase-4.5.1.0-ghc7.4.2.so()(64bit)
    libHSbytestring-0.9.2.1-ghc7.4.2.so()(64bit)
    libHScereal-0.3.5.2-ghc7.4.2.so()(64bit)
    libHScontainers-0.4.2.1-ghc7.4.2.so()(64bit)
    libHSdeepseq-1.3.0.0-ghc7.4.2.so()(64bit)
    libHSentropy-0.2.1-ghc7.4.2.so()(64bit)
    libHSghc-prim-0.2.0.0-ghc7.4.2.so()(64bit)
    libHSinteger-gmp-0.4.0.0-ghc7.4.2.so()(64bit)
    libHStagged-0.4.4-ghc7.4.2.so()(64bit)
    libHStransformers-0.3.0.0-ghc7.4.2.so()(64bit)
    libc.so.6()(64bit)
    libgmp.so.10()(64bit)
    rtld(GNU_HASH)

Provides
--------
ghc-crypto-api-devel:
    ghc-crypto-api-devel
    ghc-crypto-api-devel(x86-64)
    ghc-devel(crypto-api-0.12.2.1-321595f9c4d0101062826a29c2727ab1)

ghc-crypto-api:
    ghc(crypto-api-0.12.2.1-321595f9c4d0101062826a29c2727ab1)
    ghc-crypto-api
    ghc-crypto-api(x86-64)
    libHScrypto-api-0.12.2.1-ghc7.4.2.so()(64bit)

Unversioned so-files
--------------------
ghc-crypto-api: /usr/lib64/ghc-7.4.2/crypto-api-0.12.2.1/libHScrypto-api-0.12.2.1-ghc7.4.2.so

Source checksums
----------------
http://hackage.haskell.org/packages/archive/crypto-api/0.12.2.1/crypto-api-0.12.2.1.tar.gz :
  CHECKSUM(SHA256) this package     : 939f54b063c6791e191cda19aa8d2979844718d0a890174594445dcbb3940b0e
  CHECKSUM(SHA256) upstream package : 939f54b063c6791e191cda19aa8d2979844718d0a890174594445dcbb3940b0e

Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review -b 925987

Successful Koji builds:

F18 http://koji.fedoraproject.org/koji/taskinfo?taskID=5513584
F19 http://koji.fedoraproject.org/koji/taskinfo?taskID=5513587
F20 http://koji.fedoraproject.org/koji/taskinfo?taskID=5513643

Thanks, Shakthi


New Package SCM Request
=======================
Package Name: ghc-crypto-api
Short Description: Generic interface for cryptographic operations
Owners: petersen
Branches: f19 f18 f17 el6
InitialCC: haskell-sig

Git done (by process-git-requests).

ghc-crypto-api-0.11-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/ghc-crypto-api-0.11-2.fc18

ghc-crypto-api-0.11-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/ghc-crypto-api-0.11-2.fc19

ghc-crypto-api-0.11-1.1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/ghc-crypto-api-0.11-1.1.fc17

ghc-crypto-api-0.11-2.fc19 has been pushed to the Fedora 19 testing repository.

ghc-crypto-api-0.11-2.fc19 has been pushed to the Fedora 19 stable repository.

ghc-crypto-api-0.11-2.fc18 has been pushed to the Fedora 18 stable repository.

ghc-crypto-api-0.11-1.1.fc17 has been pushed to the Fedora 17 stable repository.