Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 928328 - interactive.singlekey does not work out of the box
Summary: interactive.singlekey does not work out of the box
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: git
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Todd Zullinger
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 927996 928950 948255
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-03-27 12:40 UTC by Petr Viktorin
Modified: 2013-04-09 16:31 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-04-09 16:31:49 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Petr Viktorin 2013-03-27 12:40:19 UTC 
Description of problem:
The manual page for git-add, section INTERACTIVE MODE, states:
You can omit having to type return here, by setting the configuration variable interactive.singlekey to true.

However, this doesn't work unless perl-TermReadKey is installed.

Version-Release number of selected component (if applicable):
git-1.8.1.4-2.fc18.x86_64
perl-TermReadKey NOT installed

How reproducible:

Steps to Reproduce:
1. (cd to a git repo with unstaged changes)
2. git config interactive.singlekey true
3. git add -p 
4. (press "y")
  
Actual results:
Nothing happens, must press Enter.

Expected results:
Hunk is added immediately.

Additional info:
http://git.661346.n2.nabble.com/question-about-interactive-singlekey-td6765652.html
Comment 1 Todd Zullinger 2013-03-27 15:53:13 UTC 
Thank for the report.  This is fixed in git-1.8.2-2.fc20, which is building now (along with git-1.8.2-2.fc19).  I imagine it will get merged to f18 at some point in the near future.
Comment 2 Todd Zullinger 2013-03-28 22:58:29 UTC 
So those builds yesterday failed, for different reasons.  Rawhide currently has an issue caused by emacs conflicting with the info package (#928950).  After that, 1.8.2 installs a new git-remote-testpy script and the generation of that package left the build root hard-coded.  I've pushed a fix for the latter issue and started a fresh build for f19.  We'll have to wait for the emacs bug to be fixed to build for rawhide.
Comment 3 Todd Zullinger 2013-04-03 21:47:25 UTC 
One emacs bug fixed, and another exposed, unfortunately. 

+ make -C contrib/emacs
make: Entering directory `/builddir/build/BUILD/git-1.8.2/contrib/emacs'
emacs -batch -f batch-byte-compile git.el
emacs: error while loading shared libraries: libgif.so.4: cannot open shared object file: No such file or directory
make: *** [git.elc] Error 127
make: Leaving directory `/builddir/build/BUILD/git-1.8.2/contrib/emacs'

I don't see that file yet, but I haven't looked very hard.  If anyone notices or files it, please feel free to update the depends on field. :)
Note You need to log in before you can comment on or make changes to this bug.