Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

[!]: Rpmlint is run on all installed packages.

nodejs-eventemitter2.noarch: W: spelling-error Summary(en_US) namespaces -> name spaces, name-spaces, names paces
nodejs-eventemitter2.noarch: W: spelling-error Summary(en_US) wildcards -> wild cards, wild-cards, wildcatters
nodejs-eventemitter2.noarch: W: spelling-error %description -l en_US namespaces -> name spaces, name-spaces, names paces
nodejs-eventemitter2.noarch: W: spelling-error %description -l en_US wildcards -> wild cards, wild-cards, wildcatters


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[-]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. No licenses
     found. Please check the source files for licenses manually.
[x]: Package consistently uses macro is (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).

===== SHOULD items =====

Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define.

===== EXTRA items =====

Generic:
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: nodejs-eventemitter2-0.4.12-1.fc20.noarch.rpm
nodejs-eventemitter2.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-eventemitter2.noarch: W: spelling-error Summary(en_US) namespaces -> name spaces, name-spaces, names paces
nodejs-eventemitter2.noarch: W: spelling-error Summary(en_US) wildcards -> wild cards, wild-cards, wildcatters
nodejs-eventemitter2.noarch: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-eventemitter2.noarch: W: spelling-error %description -l en_US namespaces -> name spaces, name-spaces, names paces
nodejs-eventemitter2.noarch: W: spelling-error %description -l en_US wildcards -> wild cards, wild-cards, wildcatters
nodejs-eventemitter2.noarch: W: only-non-binary-in-usr-lib
1 packages and 0 specfiles checked; 0 errors, 7 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint nodejs-eventemitter2
nodejs-eventemitter2.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-eventemitter2.noarch: W: spelling-error Summary(en_US) namespaces -> name spaces, name-spaces, names paces
nodejs-eventemitter2.noarch: W: spelling-error Summary(en_US) wildcards -> wild cards, wild-cards, wildcatters
nodejs-eventemitter2.noarch: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-eventemitter2.noarch: W: spelling-error %description -l en_US namespaces -> name spaces, name-spaces, names paces
nodejs-eventemitter2.noarch: W: spelling-error %description -l en_US wildcards -> wild cards, wild-cards, wildcatters
nodejs-eventemitter2.noarch: W: only-non-binary-in-usr-lib
1 packages and 0 specfiles checked; 0 errors, 7 warnings.
# echo 'rpmlint-done:'



Requires
--------
nodejs-eventemitter2 (rpmlib, GLIBC filtered):
    nodejs(engine)



Provides
--------
nodejs-eventemitter2:
    nodejs-eventemitter2
    npm(eventemitter2)



Source checksums
----------------
http://registry.npmjs.org/eventemitter2/-/eventemitter2-0.4.12.tgz :
  CHECKSUM(SHA256) this package     : 466b3aa03fe384b46c8384ec7cc42248117a70e9b48c0e20706889b97edcdeac
  CHECKSUM(SHA256) upstream package : 466b3aa03fe384b46c8384ec7cc42248117a70e9b48c0e20706889b97edcdeac


Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29
Buildroot used: compton-rawhide-x86_64
Command line :/usr/bin/fedora-review -m compton-rawhide-x86_64 -b 977120

(In reply to Tom Hughes from comment #1)
> [!]: Rpmlint is run on all installed packages.
> 
> nodejs-eventemitter2.noarch: W: spelling-error Summary(en_US) namespaces ->
> name spaces, name-spaces, names paces
> nodejs-eventemitter2.noarch: W: spelling-error Summary(en_US) wildcards ->
> wild cards, wild-cards, wildcatters
> nodejs-eventemitter2.noarch: W: spelling-error %description -l en_US
> namespaces -> name spaces, name-spaces, names paces
> nodejs-eventemitter2.noarch: W: spelling-error %description -l en_US
> wildcards -> wild cards, wild-cards, wildcatters

Personally I think namespaces and wilcards are pretty acceptable. Both see fairly common usage in computing.

Yes, that seems reasonable to me. Package approved.

New Package SCM Request
=======================
Package Name: nodejs-eventemitter2
Short Description: A Node.js event emitter implementation with namespaces, wildcards and TTL
Owners: jamielinux patches
Branches: f18 f19 el6
InitialCC:

Git done (by process-git-requests).