Description of problem:

The davix source tree contains many libraries that should be unbundled according to the guidelines.

https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries

deps/libneon/

 → Use BuildRequires: neon-devel instead

deps/strlcpy/

 → Use BuildRequires: libbsd-devel instead
   #include <bsd/string.h>
   -lbsd

test/gtest-1.6.0/

 → Use BuildRequires: gtest-devel instead

test/pywebdav/

 → Use BuildRequires; pywebdav instead

Other code in the deps/* directories should be investigated to assess whether they are bundled or not.

Unused bundled code should be deleted in %prep so that it is no accidentally used during the build.

Version-Release number of selected component (if applicable):

davix-0.2.2-2


Additional info:

There are some other minor packaging issues in the spec as well:

The main davix package depends on the davix-libs package and these are build from the same srpm → the davix package should have a fully versioned dependency on davix-libs:

Requires: %{name}-libs%{?_isa} = %{version}-%{release}

The doc subpackage should be noarch where supported, i.e. except on EPEL 5:

%if %{?fedora}%{!?fedora:0} >= 10 || %{?rhel}%{!?rhel:0} >= 6
BuildArch:	noarch
%endif

The doc package depends on the main package, but contains documentation about the api of the library, so this dependency does not make sense. It could depend on the library package instead, or have no dependency at all. (If the dependency is removed the LICENSE file should be added to the doc package.)