Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 998638 - please build and package EFI Shell
Summary: please build and package EFI Shell
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: edk2
Version: 24
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Paolo Bonzini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-08-19 16:26 UTC by Kay Sievers
Modified: 2016-05-21 12:47 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-05-21 12:47:32 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
build and sub-package EFI Shell (2.38 KB, patch)
2013-08-19 16:26 UTC, Kay Sievers
no flags Details | Diff

Description Kay Sievers 2013-08-19 16:26:57 UTC
Created attachment 788152 [details]
build and sub-package EFI Shell

Attached is a patch to the spec file that does that. Thanks!

Comment 1 Cole Robinson 2013-08-20 18:33:05 UTC
Thanks for the patch, pushed to git now. Currently blocked from rawhide until we fix https://bugzilla.redhat.com/show_bug.cgi?id=992180 though.

Comment 2 Kay Sievers 2013-08-20 19:34:19 UTC
Oh, damn, this needs to build on the stone-age 32bit arch? This is still
useful and used?

If that is really needed, we should try to fix up the build, at the
moment, only 64bit builds are supported. Please let me know, I can take
a look ...

Comment 3 Laszlo Ersek 2013-08-21 13:08:46 UTC
I don't know why ARM was added at all to the target arches. In dist-git, it appeared in commit

commit 1516367bfab219109804409e5300ecdd1bcb4254
Author: Dan Horák <dan>
Date:   Thu May 23 08:16:31 2013 +0200

    set ExclusiveArch

without any explanation at all.

+ExclusiveArch: %{ix86} x86_64 %{arm}

Comment 4 Cole Robinson 2013-08-21 13:28:01 UTC
(In reply to Laszlo Ersek from comment #3)
> I don't know why ARM was added at all to the target arches. In dist-git, it
> appeared in commit
> 
> commit 1516367bfab219109804409e5300ecdd1bcb4254
> Author: Dan Horák <dan>
> Date:   Thu May 23 08:16:31 2013 +0200
> 
>     set ExclusiveArch
> 
> without any explanation at all.
> 
> +ExclusiveArch: %{ix86} x86_64 %{arm}

Dan works on fedora s390. edk2 likely didn't build there, so he added the ExclusiveArch, but just included every other architecture. So the package may not make sense for arm.

Long term, if we build OVMF, edk2 needs to only be compiled for x86, but the package needs to be available on all architectures (so qemu-system-x86 is available on all architectures). To do that we need to cross-compile, and that makes the package noarch which means we can drop the ExclusiveArch handling.

Comment 5 Paolo Bonzini 2013-08-29 13:40:02 UTC
The EFI shell should be in a noarch subpackage.  If Kay wants both 32-bit and 64-bit shell binaries, he should build the ShellPkg twice.  So in fact I suggest reverting both of Kay's patches.

Comment 6 Cole Robinson 2013-08-29 17:22:39 UTC
(In reply to Paolo Bonzini from comment #5)
> The EFI shell should be in a noarch subpackage.  If Kay wants both 32-bit
> and 64-bit shell binaries, he should build the ShellPkg twice.  So in fact I
> suggest reverting both of Kay's patches.

I'm trying to understand. Why should efi-shell be inside a noarch package? is it an external tool, or something run inside the guest? My understanding is that we only do 'compile for x86 and stuff in a noarch package' for things that we pass into a guest from the qemu command line or similar (maybe that covers efi-shell but I'm ignorant here and googling didn't explain things).

Comment 7 Paolo Bonzini 2013-09-03 12:58:19 UTC
The EFI shell is not needed inside the guest, since the OVMF ROM already includes it.  My guest is that Kay wants an easy way to get an EFI shell for his computer.

It has to be noarch because it doesn't include any Linux binaries.  You could even use a 64-bit shell on a 32-bit installation, that would make sense.

Comment 8 Fedora End Of Life 2013-09-16 16:36:23 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 20 development cycle.
Changing version to '20'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora20

Comment 9 Fedora End Of Life 2015-05-29 09:20:09 UTC
This message is a reminder that Fedora 20 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 20. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '20'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 20 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 10 Cole Robinson 2015-05-31 18:45:27 UTC
Still relevant with latest packages

Comment 11 Cole Robinson 2016-05-20 19:08:58 UTC
Gerd, I see edk2-ovmf has /usr/share/edk2/ovmf/Shell.efi , does that cover this request?

Comment 12 Gerd Hoffmann 2016-05-21 06:20:35 UTC
(In reply to Cole Robinson from comment #11)
> Gerd, I see edk2-ovmf has /usr/share/edk2/ovmf/Shell.efi , does that cover
> this request?

Yes.

Comment 13 Cole Robinson 2016-05-21 12:47:32 UTC
Thanks. This is in f24/rawhide then. Will probably push to f23 eventually


Note You need to log in before you can comment on or make changes to this bug.