Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1136994
Summary: | GTK+3 themes must be updated for upstream checkbox 'checked' state | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Adam Williamson <awilliam> |
Component: | mate-themes | Assignee: | Wolfgang Ulbrich <fedora> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 21 | CC: | dan.mashal, fedora, mclasen, satellitgo |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | mate-themes-1.9.1-0.2.git20140914.503ae60.fc21 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2014-10-01 04:15:07 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1043122 |
Description
Adam Williamson
2014-09-03 19:15:42 UTC
*** Bug 1136570 has been marked as a duplicate of this bug. *** whoow, great work to break themes in beta phase, thank you overlords :) I will look into it. PS: better you provide a link to git gnome adwaita theme The adwaita changes are part of the (large) GTK+ commit linked above - it both implements the change, and adjusts adwaita for it. Here is the change in HighContrast, for comparison https://git.gnome.org/browse/gnome-themes-standard/commit/?id=54623b684e909f53a295172e1d5388cbc69e3050 Thanks all for helping. Due a lack of time in the next 1.5 months for personal reasons, i can't adjust the BlueMenta theme now, but i'm optimistic to do that before f21 release. As a temporarily solution i will add those lines to mate-compiz kickstart file if i've access for the spin-kickstart repo. # temporarily fix for theme issue with anaconda rhbz (#1136994) sed -i "s/^gtk-theme='BlueMenta'/gtk-theme='Adwaita'/" /usr/share/glib-2.0/schemas/mate-fedora.gschema.override This is tested with a local livecd build and works like a charm. In result the livecd use the Adwaita theme and after installation MATE use the default BlueMenta theme. This issue is going to affect anything that uses checkboxes (or one of several similar widgets) after installation too, I think. It's not just about anaconda. I know, ie. Network-manager and dconf-editor in mate. But i don't have the time to fix the theme now. I'm in the the hot phase of my LPI-2 certification exam. Sorry. But it would be helpful for the momment if someone would grant me some rights for editing the kickstart repo. https://lists.fedoraproject.org/pipermail/spins/2014-September/003798.html https://git.fedorahosted.org/cgit/spin-kickstarts.git/commit/?h=f21&id=cbb3d8a73d812cc2162dcbf234cdeb2aa6ccb22f So, the main issue with anaconda is fixed. "Installing Mate from livecd is now possible" That's not what the bug report is for. The bug report is 'the GTK+ themes don't work right any more'. This hasn't been addressed at all. Setting back to ASSIGNED. Discussed at 2014-09-10 freeze exception review meeting: http://meetbot.fedoraproject.org/fedora-blocker-review/2014-09-10/f21-blocker-review.2014-09-10-16.07.log.txt . Accepted as a freeze exception issue - the spin-kickstarts hack will work around this for the very specific case of the live installer, but we accept it as an FE issue so if anyone gets time to actually fix the themes properly soon, we can take a better fix into Alpha. Didn't somebody else have patches for several themes, in some other bug ? Hey Mister Twister Overlord, apply! MATE Desktop themes Update to the latest git commit d832073 2014-07-20 & catch up gtk3 https://bugzilla.redhat.com/show_bug.cgi?id=1140423 Happy Campers. :) mate-themes-1.9.1-0.1.git20140720.d832073.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/mate-themes-1.9.1-0.1.git20140720.d832073.fc21 Thank you very much poma :) I've adjust your patch for BlueMenta and Menta a bit, to avoid that checkboxes are invisible with mouseover, in result Mate don't have to use symbolic-icons haters. http://pkgs.fedoraproject.org/cgit/mate-themes.git/tree/mate-themes_menta-themes-GTK3-sync.patch Those are our main themes, for the rest i will adjust your great patch (it's include) later if i've more spare time. So the main issue is fixed, imo. In anaconda the checkboxes and the installer screen is now visible. Also menu from NetworkManager displays well. Pls test, i wanna remove the hack in kickstart file if m-t is in stable. again thanks all for your help mate-themes-1.9.1-0.1.git20140720.d832073.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. mate-themes-1.9.1-0.2.git20140914.503ae60.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/mate-themes-1.9.1-0.2.git20140914.503ae60.fc21 <raveit65> satellit, hi, i've fixed check and radio buttons issue with all themes from mate-themes, BlueMenta and Menta themes are working well now with anaconda. https://admin.fedoraproject.org/updates/mate-themes-1.9.1-0.2.git20140914.503ae60.fc21?_csrf_token=29a1d92f976c1ed206f6b69d5ce09c8220d4e454 pls test and leave karma Package mate-themes-1.9.1-0.2.git20140914.503ae60.fc21: * should fix your issue, * was pushed to the Fedora 21 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing mate-themes-1.9.1-0.2.git20140914.503ae60.fc21' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-11597/mate-themes-1.9.1-0.2.git20140914.503ae60.fc21 then log in and leave karma (feedback). mate-themes-1.9.1-0.2.git20140914.503ae60.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. |