Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1136994 - GTK+3 themes must be updated for upstream checkbox 'checked' state
Summary: GTK+3 themes must be updated for upstream checkbox 'checked' state
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: mate-themes
Version: 21
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Wolfgang Ulbrich
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1136570 (view as bug list)
Depends On:
Blocks: F21AlphaFreezeException
TreeView+ depends on / blocked
 
Reported: 2014-09-03 19:15 UTC by Adam Williamson
Modified: 2014-10-01 04:15 UTC (History)
4 users (show)

Fixed In Version: mate-themes-1.9.1-0.2.git20140914.503ae60.fc21
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-10-01 04:15:07 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Adam Williamson 2014-09-03 19:15:42 UTC 
Upstream GTK+ 3 made a change to how checkboxes are handled:

https://bugzilla.gnome.org/show_bug.cgi?id=733967
https://git.gnome.org/browse/gtk+/commit/?id=4e077d4638b4ecfaf67afbab5082b9d47499af4f

basically the 'checked' state is, since 3.13.7, GTK_STATE_FLAG_CHECKED not GTK_STATE_FLAG_ACTIVE . This state didn't exist prior to 3.13.7, so to maintain backward compatibility you have to handle either. Here's KDE fixing their theme, for instance:

https://projects.kde.org/projects/playground/artwork/oxygen-gtk/repository/revisions/5f97a2d3f8880eb68ce2e0fd44285b6adc38293e

Proposing as a freeze exception issue, as this affects the appearance of anaconda on the MATE live image.
Comment 1 David Shea 2014-09-03 20:57:44 UTC 
*** Bug 1136570 has been marked as a duplicate of this bug. ***
Comment 2 Wolfgang Ulbrich 2014-09-03 22:10:05 UTC 
whoow, great work to break themes in beta phase, thank you overlords :)
I will look into it.
Comment 3 Wolfgang Ulbrich 2014-09-03 22:14:51 UTC 
PS: better you provide a link to git gnome adwaita theme
Comment 4 Adam Williamson 2014-09-04 15:22:28 UTC 
The adwaita changes are part of the (large) GTK+ commit linked above - it both implements the change, and adjusts adwaita for it.
Comment 5 Matthias Clasen 2014-09-05 17:37:56 UTC 
Here is the change in HighContrast, for comparison

https://git.gnome.org/browse/gnome-themes-standard/commit/?id=54623b684e909f53a295172e1d5388cbc69e3050
Comment 6 Wolfgang Ulbrich 2014-09-06 12:05:45 UTC 
Thanks all for helping.
Due a lack of time in the next 1.5 months for personal reasons, i can't adjust the BlueMenta theme now, but i'm optimistic to do that before f21 release.
As a temporarily solution i will add those lines to mate-compiz kickstart file if i've access for the spin-kickstart repo.

# temporarily fix for theme issue with anaconda rhbz (#1136994)
sed -i "s/^gtk-theme='BlueMenta'/gtk-theme='Adwaita'/" /usr/share/glib-2.0/schemas/mate-fedora.gschema.override

This is tested with a local livecd build and works like a charm.
In result the livecd use the Adwaita theme and after installation MATE use the default BlueMenta theme.
Comment 7 Adam Williamson 2014-09-06 15:17:01 UTC 
This issue is going to affect anything that uses checkboxes (or one of several similar widgets) after installation too, I think. It's not just about anaconda.
Comment 8 Wolfgang Ulbrich 2014-09-06 15:34:01 UTC 
I know, ie. Network-manager and dconf-editor in mate.
But i don't have the time to fix the theme now.
I'm in the the hot phase of my LPI-2 certification exam.
Sorry.

But it would be helpful for the momment if someone would grant me some rights for editing the kickstart repo.
https://lists.fedoraproject.org/pipermail/spins/2014-September/003798.html
Comment 9 Wolfgang Ulbrich 2014-09-07 06:56:00 UTC 
https://git.fedorahosted.org/cgit/spin-kickstarts.git/commit/?h=f21&id=cbb3d8a73d812cc2162dcbf234cdeb2aa6ccb22f

So, the main issue with anaconda is fixed. "Installing Mate from livecd is now possible"
Comment 10 Adam Williamson 2014-09-10 17:47:17 UTC 
That's not what the bug report is for. The bug report is 'the GTK+ themes don't work right any more'. This hasn't been addressed at all. Setting back to ASSIGNED.
Comment 11 Adam Williamson 2014-09-10 17:55:41 UTC 
Discussed at 2014-09-10 freeze exception review meeting: http://meetbot.fedoraproject.org/fedora-blocker-review/2014-09-10/f21-blocker-review.2014-09-10-16.07.log.txt . Accepted as a freeze exception issue - the spin-kickstarts hack will work around this for the very specific case of the live installer, but we accept it as an FE issue so if anyone gets time to actually fix the themes properly soon, we can take a better fix into Alpha.
Comment 12 Matthias Clasen 2014-09-10 18:16:14 UTC 
Didn't somebody else have patches for several themes, in some other bug ?
Comment 13 poma 2014-09-11 00:12:42 UTC 
Hey Mister Twister Overlord, apply!

MATE Desktop themes
Update to the latest git commit d832073 2014-07-20 & catch up gtk3
https://bugzilla.redhat.com/show_bug.cgi?id=1140423

Happy Campers. :)
Comment 14 Fedora Update System 2014-09-11 19:57:21 UTC 
mate-themes-1.9.1-0.1.git20140720.d832073.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/mate-themes-1.9.1-0.1.git20140720.d832073.fc21
Comment 15 Wolfgang Ulbrich 2014-09-11 20:15:26 UTC 
Thank you very much poma :)
I've adjust  your patch for BlueMenta and Menta a bit, to avoid that checkboxes are invisible with mouseover, in result Mate don't have to use symbolic-icons haters.
http://pkgs.fedoraproject.org/cgit/mate-themes.git/tree/mate-themes_menta-themes-GTK3-sync.patch
Those are our main themes, for the rest i will adjust your great patch (it's include) later if i've more spare time.

So the main issue is fixed, imo.
In anaconda the checkboxes and the installer screen is now visible.
Also menu from NetworkManager displays well.
Pls test, i wanna remove the hack in kickstart file if m-t is in stable.

again thanks all for your help
Comment 16 Fedora Update System 2014-09-23 05:11:41 UTC 
mate-themes-1.9.1-0.1.git20140720.d832073.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 17 Fedora Update System 2014-09-24 17:47:41 UTC 
mate-themes-1.9.1-0.2.git20140914.503ae60.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/mate-themes-1.9.1-0.2.git20140914.503ae60.fc21
Comment 18 satellitgo 2014-09-24 18:21:03 UTC 
<raveit65> satellit, hi, i've fixed check and radio buttons issue with all themes from mate-themes, BlueMenta and Menta themes are working well now with anaconda. https://admin.fedoraproject.org/updates/mate-themes-1.9.1-0.2.git20140914.503ae60.fc21?_csrf_token=29a1d92f976c1ed206f6b69d5ce09c8220d4e454  pls test and leave karma
Comment 19 Fedora Update System 2014-09-27 09:43:04 UTC 
Package mate-themes-1.9.1-0.2.git20140914.503ae60.fc21:
* should fix your issue,
* was pushed to the Fedora 21 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing mate-themes-1.9.1-0.2.git20140914.503ae60.fc21'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-11597/mate-themes-1.9.1-0.2.git20140914.503ae60.fc21
then log in and leave karma (feedback).
Comment 20 Fedora Update System 2014-10-01 04:15:07 UTC 
mate-themes-1.9.1-0.2.git20140914.503ae60.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.