Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1169124
Summary: | Review Request: nodejs-domutils - Utilities for working with htmlparser2's dom | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Piotr Popieluch <piotr1212> |
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | jsmith.fedora, package-review, panemade |
Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | nodejs-domutils-1.5.0-2.el7 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2014-12-14 12:38:40 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1169118 | ||
Bug Blocks: | 956806, 1169137, 1271795, 1387531 |
Description
Piotr Popieluch
2014-11-30 14:05:42 UTC
Review: + Package built successful in mock (f22 x86_64) + rpmlint on generated rpms gave output nodejs-domutils.noarch: W: spelling-error Summary(en_US) dom -> mod, dim, don nodejs-domutils.noarch: W: spelling-error %description -l en_US dom -> mod, dim, don nodejs-domutils.noarch: W: only-non-binary-in-usr-lib nodejs-domutils.noarch: W: dangling-symlink /usr/lib/node_modules/domutils/node_modules/domelementtype /usr/lib/node_modules/domelementtype nodejs-domutils.src: W: spelling-error Summary(en_US) dom -> mod, dim, don nodejs-domutils.src: W: spelling-error %description -l en_US dom -> mod, dim, don 2 packages and 0 specfiles checked; 0 errors, 6 warnings. + Source verified with upstream as (sha256sum) srpm tarball: d7c41dfdd698bcb0660b14804ace033dd93256c7112b394689d01843a582721b upstream tarball: d7c41dfdd698bcb0660b14804ace033dd93256c7112b394689d01843a582721b - License is "BSD" and not "MIT" + License is included in its own LICENSE file. + follows nodejs packaging guidelines. Suggestions: 1) Group is optional and required only for EL5 2) Fix license tag fixed in: Spec URL: https://piotrp.fedorapeople.org/nodejs-domutils.spec SRPM URL: https://piotrp.fedorapeople.org/nodejs-domutils-1.5.0-2.fc21.src.rpm Looks good now. APPROVED. New Package SCM Request ======================= Package Name: nodejs-domutils Short Description: Utilities for working with htmlparser2's dom Upstream URL: https://github.com/FB55/domutils Owners: piotrp Branches: f19 f20 f21 el6 epel7 InitialCC: piotrp Git done (by process-git-requests). nodejs-domutils-1.5.0-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-domutils-1.5.0-2.fc21 nodejs-domutils-1.5.0-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-domutils-1.5.0-2.fc20 nodejs-domutils-1.5.0-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-domutils-1.5.0-2.fc19 nodejs-domutils-1.5.0-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/nodejs-domutils-1.5.0-2.el7 nodejs-domutils-1.5.0-2.el7 has been pushed to the Fedora EPEL 7 testing repository. Package built and in testing, closing bug. nodejs-domutils-1.5.0-2.fc20 has been pushed to the Fedora 20 stable repository. nodejs-domutils-1.5.0-2.fc21 has been pushed to the Fedora 21 stable repository. nodejs-domutils-1.5.0-2.fc19 has been pushed to the Fedora 19 stable repository. nodejs-domutils-1.5.0-2.el7 has been pushed to the Fedora EPEL 7 stable repository. *** Bug 1271829 has been marked as a duplicate of this bug. *** |