Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 166700
| Summary: | Review Request: perl-Time-Piece-MySQL - MySQL-specific methods for Time::Piece | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chris Grau <chris> | ||||
| Component: | Package Review | Assignee: | Paul Howarth <paul> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | fedora-extras-list | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | http://www.chrisgrau.com/packages/perl/perl-Time-Piece-MySQL-0.05-1.src.rpm | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2005-08-25 16:35:51 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 166698 | ||||||
| Bug Blocks: | 163779 | ||||||
| Attachments: |
|
||||||
|
Description
Chris Grau
2005-08-24 18:37:23 UTC
Review:
- rpmlint clean
- package and spec naming OK
- package meets guidelines
- license is same as perl, correct in spec
- spec file written in English and legible
- sources match upstream
- package build ok in mock on FC4 (i386)
- no locales, libraries, subpackages, pkgconfigs etc. to worry about
- not relocatable
- no permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code not content
- no large docs
- docs don't affect runtime
- no scriptlets
Needswork:
- directory ownership wrong; perl(Time::Piece) owns
%{perl_vendorarch)/Time/Piece/
not
%{perl_vendorlib}/Time/Piece/
So you need to replace in %files:
# Time and Time/Piece owned by perl-Time-Piece.
%{perl_vendorlib}/Time/Piece/MySQL.pm
with:
%{perl_vendorlib}/Time/
Nitpick:
- BR: perl is redundant
- license text not included; suggest adding to %setup:
perldoc -t perlgpl > COPYING
perldoc -t perlartistic > Artistic
and to %files:
%doc COPYING Artistic
Created attachment 118093 [details]
Patch addressing review issues
(In reply to comment #1) > - directory ownership wrong; perl(Time::Piece) owns > %{perl_vendorarch)/Time/Piece/ > not > %{perl_vendorlib}/Time/Piece/ > So you need to replace in %files: > > # Time and Time/Piece owned by perl-Time-Piece. > %{perl_vendorlib}/Time/Piece/MySQL.pm > > with: > > %{perl_vendorlib}/Time/ Oops. Can't even begin to explain what I was thinking there. Good catch. Fixed applied: http://www.chrisgrau.com/packages/perl/perl-Time-Piece-MySQL.spec http://www.chrisgrau.com/packages/perl/perl-Time-Piece-MySQL-0.05-2.src.rpm Again, I didn't use your patch, Paul, but I appreciate the effort. Approved. |