Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 166700 - Review Request: perl-Time-Piece-MySQL - MySQL-specific methods for Time::Piece
Summary: Review Request: perl-Time-Piece-MySQL - MySQL-specific methods for Time::Piece
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Paul Howarth
QA Contact: David Lawrence
URL: http://www.chrisgrau.com/packages/per...
Whiteboard:
Depends On: 166698
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2005-08-24 18:37 UTC by Chris Grau
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2005-08-25 16:35:51 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Patch addressing review issues (1.27 KB, patch)
2005-08-24 20:43 UTC, Paul Howarth
no flags Details | Diff

Description Chris Grau 2005-08-24 18:37:23 UTC
Spec Name or Url: http://www.chrisgrau.com/packages/perl/perl-Time-Piece-MySQL.spec
SRPM Name or Url: http://www.chrisgrau.com/packages/perl/perl-Time-Piece-MySQL-0.05-1.src.rpm
Description: 
The Time::Piece::MySQL module can be used instead of, or in addition to,
Time::Piece to add MySQL-specific date-time methods to Time::Piece objects.

Comment 1 Paul Howarth 2005-08-24 20:38:48 UTC
Review:

- rpmlint clean
- package and spec naming OK
- package meets guidelines
- license is same as perl, correct in spec
- spec file written in English and legible
- sources match upstream
- package build ok in mock on FC4 (i386)
- no locales, libraries, subpackages, pkgconfigs etc. to worry about
- not relocatable
- no permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code not content
- no large docs
- docs don't affect runtime
- no scriptlets

Needswork:

- directory ownership wrong; perl(Time::Piece) owns
  %{perl_vendorarch)/Time/Piece/
  not
  %{perl_vendorlib}/Time/Piece/
  So you need to replace in %files:

  # Time and Time/Piece owned by perl-Time-Piece.
  %{perl_vendorlib}/Time/Piece/MySQL.pm

  with:

  %{perl_vendorlib}/Time/

Nitpick:

- BR: perl is redundant
- license text not included; suggest adding to %setup:
  perldoc -t perlgpl > COPYING
  perldoc -t perlartistic > Artistic
  and to %files:
  %doc COPYING Artistic


Comment 2 Paul Howarth 2005-08-24 20:43:32 UTC
Created attachment 118093 [details]
Patch addressing review issues

Comment 3 Chris Grau 2005-08-24 21:01:31 UTC
(In reply to comment #1)
> - directory ownership wrong; perl(Time::Piece) owns
>   %{perl_vendorarch)/Time/Piece/
>   not
>   %{perl_vendorlib}/Time/Piece/
>   So you need to replace in %files:
> 
>   # Time and Time/Piece owned by perl-Time-Piece.
>   %{perl_vendorlib}/Time/Piece/MySQL.pm
> 
>   with:
> 
>   %{perl_vendorlib}/Time/

Oops.  Can't even begin to explain what I was thinking there.  Good catch.

Fixed applied:
http://www.chrisgrau.com/packages/perl/perl-Time-Piece-MySQL.spec
http://www.chrisgrau.com/packages/perl/perl-Time-Piece-MySQL-0.05-2.src.rpm

Again, I didn't use your patch, Paul, but I appreciate the effort.


Comment 4 Paul Howarth 2005-08-24 21:04:52 UTC
Approved.



Note You need to log in before you can comment on or make changes to this bug.