Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 179707
Summary: | Review Request: dap-server - Basic request handling for DAP servers | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Patrice Dumas <pertusus> |
Component: | Package Review | Assignee: | Ed Hill <ed> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-extras-list |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-02-20 12:41:46 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 179708, 179709, 179710 | ||
Bug Blocks: | 163779 |
Description
Patrice Dumas
2006-02-02 09:59:07 UTC
Hi Patrice, I've been meaning to look at this so, since today is the first scheduled FE "review day", heres a quick review: good: + source matches upstream + license is correctly included + spec is very legible--no obvious errors + builds on FC4 (not in mock) + rpmlint reports: E: dap-server non-standard-uid /var/cache/dap-server apache E: dap-server non-standard-gid /var/cache/dap-server apache W: dap-server-cgi no-documentation E: dap-server-cgi non-standard-uid \ /etc/httpd/conf.d/opendap_apache.conf apache ...and a few more of the same apache uid/gid errors... which can probably be safely ignored + dir ownership is OK + no shared libs + clean(s) are properly done nits: - License is LGPL not GPL - fails to build with "mock -r fedora-development-i386-core $SRPM" and returns the following error message: make[2]: Entering directory `/builddir/build/BUILD/dap-server-3.5.3' if g++ -DHAVE_CONFIG_H -I. -I. -I. -I/usr/include/libdap -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -MT usage.o -MD -MP -MF ".deps/usage.Tpo" -c -o usage.o usage.cc; \ then mv -f ".deps/usage.Tpo" ".deps/usage.Po"; else rm -f ".deps/usage.Tpo"; exit 1; fi /usr/include/libdap/GNURegex.h:45: error: extra qualification 'Regex::' on member 'init' Do you know whats the matter with devel at the moment? I realize its not a blocker, I'm just curious whats causing the problem -- and don't have a lot of time right now to look at the syntax... It is certainly a non conformant construct revealed by the newer gcc. It is in fact in the libdap package and I have reported it upstream. (and the libdap package cannot be rebuilt in devel). (In reply to comment #1) > Do you know whats the matter with devel at the moment? I realize its > not a blocker, I'm just curious whats causing the problem -- and don't > have a lot of time right now to look at the syntax... See https://www.redhat.com/archives/fedora-test-list/2005-December/msg00382.html for an explanation of the problem, as Patrice tells this is a problem of the code and the fix is simple, remove the offending code. :-) This is fixed in upstream libdap svn. It also seems that a new libdap version is on tracks. I'll update libdap as soon as it is out and this should build in devel then. Ok, glad to hear the gcc problem is being fixed upstream. Please change the license to LGPL before checking it in and, since I don't see any other blockers (comment #1), this package is APPROVED. |