Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 189603

Summary:	Review Request: libgalago
Product:	[Fedora] Fedora	Reporter:	Brian Pepple <bdpepple>
Component:	Package Review	Assignee:	John Mahowald <jpmahowald>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-05-17 18:28:22 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779, 189609

Description Brian Pepple 2006-04-21 15:28:21 UTC

Spec URL: http://piedmont.homelinux.org/fedora/galago/libgalago.spec
SRPM URL: http://piedmont.homelinux.org/fedora/galago/libgalago-0.5.0-1.src.rpm
Description: Galago presence library

I'll be posting the rest of the galago packages in the next day or so.

Comment 1 John Mahowald 2006-05-16 16:38:07 UTC

- rpmlint checks return clean
- package meets naming guidelines
- package meets packaging guidelines
- license (LGPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on FC5 (x86_64)
- no missing BR
- no unnecessary BR
- locales handled with %find_lang
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

- devel package ok
- no .la files
- post/postun ldconfig ok
- devel requires base package n-v-r 

* URL redirects to some game page, use http://www.galago-project.org/
* minor typo: againse --> against

APPROVED

Comment 2 Brian Pepple 2006-05-17 18:28:22 UTC

Built for FC5 & devel.