Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 189603 - Review Request: libgalago
Summary: Review Request: libgalago
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: John Mahowald
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT 189609
TreeView+ depends on / blocked
 
Reported: 2006-04-21 15:28 UTC by Brian Pepple
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-05-17 18:28:22 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Brian Pepple 2006-04-21 15:28:21 UTC
Spec URL: http://piedmont.homelinux.org/fedora/galago/libgalago.spec
SRPM URL: http://piedmont.homelinux.org/fedora/galago/libgalago-0.5.0-1.src.rpm
Description: Galago presence library

I'll be posting the rest of the galago packages in the next day or so.

Comment 1 John Mahowald 2006-05-16 16:38:07 UTC
- rpmlint checks return clean
- package meets naming guidelines
- package meets packaging guidelines
- license (LGPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on FC5 (x86_64)
- no missing BR
- no unnecessary BR
- locales handled with %find_lang
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

- devel package ok
- no .la files
- post/postun ldconfig ok
- devel requires base package n-v-r 

* URL redirects to some game page, use http://www.galago-project.org/
* minor typo: againse --> against

APPROVED

Comment 2 Brian Pepple 2006-05-17 18:28:22 UTC
Built for FC5 & devel.


Note You need to log in before you can comment on or make changes to this bug.