Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 189609 - Review Request: galago-daemon
Summary: Review Request: galago-daemon
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: John Mahowald
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On: 189603
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-04-21 15:53 UTC by Brian Pepple
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-05-19 16:20:58 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Brian Pepple 2006-04-21 15:53:11 UTC
Spec URL: http://piedmont.homelinux.org/fedora/galago/galago-daemon.spec
SRPM URL: http://piedmont.homelinux.org/fedora/galago/galago-daemon-0.5.0-1.src.rpm
Description: The Galago presence daemon, which is the center of all presence transactions for Galago. This service is automatically launched by D-BUS when needed.

Comment 1 John Mahowald 2006-05-17 20:11:24 UTC
- rpmlint checks return:
W: galago-daemon non-conffile-in-etc /etc/dbus-1/system.d/galago-daemon.conf
A non-executable file in your package is being installed in /etc, but is not
a configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.

W: galago-daemon non-standard-dir-in-usr libexec
Non standard but not without precedent. I'm inclined to ignore.

- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on FC5 (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

APPROVED

Comment 2 John Mahowald 2006-05-17 20:13:53 UTC
- rpmlint checks return:
W: galago-daemon non-conffile-in-etc /etc/dbus-1/system.d/galago-daemon.conf
A non-executable file in your package is being installed in /etc, but is not
a configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.

W: galago-daemon non-standard-dir-in-usr libexec
Non standard but not without precedent. I'm inclined to ignore.

- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on FC5 (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

Mark the config file as %config

APPROVED

Comment 3 Brian Pepple 2006-05-19 16:20:58 UTC
Packages built for FC5 & Devel.  Thanks for the review.


Note You need to log in before you can comment on or make changes to this bug.