Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 2048084
| Summary: | b43-tools provides python3dist(b43-debug-tools) = 0 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Miro Hrončok <mhroncok> |
| Component: | b43-tools | Assignee: | Pete Walter <walter.pete> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 38 | CC: | lemenkov, walter.pete |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | b43-tools-019-17.fc39 b43-tools-019-17.fc38 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-03-14 09:49:41 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2117176, 2168842, 2048077 | ||
|
Description
Miro Hrončok
2022-01-29 12:13:04 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 36 development cycle. Changing version to 36. https://fedoraproject.org/wiki/Changes/Prevent-Providing-python3dist(pkg)=0 has landed and this package will now fail to build in Fedora 38+. Please, respond to this bugzilla, it has been open for a year. I don't know what to do with it. Can you help please? Should I put 'SETUPTOOLS_SCM_PRETEND_VERSION=%{version}' somewhere?
I am not very familiar with the package as I only picked it up to avoid retirement.
Sure thing. Let me see...
------------------------------------------------
$ fedpkg clone b43-tools
$ cd b43-tools
$ fedpkg prep
$ cd b43-tools-019/
$ fd 'setup\.py'
debug/setup.py
$ cat debug/setup.py
#!/usr/bin/env python
#
# Run this script as root to install the debugging tools
#
from distutils.core import setup
import sys
if len(sys.argv) == 1:
sys.argv.append("install") # default to INSTALL
setup(
name="B43-debug-tools",
py_modules=["libb43"],
scripts=["b43-fwdump", "b43-beautifier"]
)
------------------------------------------------
This setup.py script is missing version entirely. Let's hack some version in:
------------------------------------------------
$ git diff
diff --git a/b43-tools.spec b/b43-tools.spec
index 948f40d..7e11a9c 100644
--- a/b43-tools.spec
+++ b/b43-tools.spec
...
# For py3_build/py3_install macros
-install -p -m 0644 debug/install.py debug/setup.py
+sed 's/py_modules=/version="%{version}", py_modules=/' debug/install.py > debug/setup.py
------------------------------------------------
$ fedpkg mockbuild
...
Provides: b43-tools = 019-16.fc39 b43-tools(x86-64) = 019-16.fc39 python3.11dist(b43-debug-tools) = 19 python3dist(b43-debug-tools) = 19
...
------------------------------------------------
That should make it build but it's not nice. You might prefer a patch or similar. Note that distutils is deprecated so this setup.py script will need upstream changes anyway if they want to support Python 3.12+.
Thank you! I had no idea where to even look. I'll go ahead and use the sed hack for now and perhaps we need to drop this entirely when Python 3.12 lands in Fedora. FEDORA-2023-e48c084d77 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-e48c084d77 FEDORA-2023-e48c084d77 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-e2059d8df7 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-e2059d8df7 FEDORA-2023-e2059d8df7 has been pushed to the Fedora 38 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-e2059d8df7 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-e2059d8df7 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. |