Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 2048084 - b43-tools provides python3dist(b43-debug-tools) = 0
Summary: b43-tools provides python3dist(b43-debug-tools) = 0
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: b43-tools
Version: 38
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Pete Walter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F38FTBFS F39FTBFS python3dist0
TreeView+ depends on / blocked
 
Reported: 2022-01-29 12:13 UTC by Miro Hrončok
Modified: 2023-03-23 00:15 UTC (History)
2 users (show)

Fixed In Version: b43-tools-019-17.fc39 b43-tools-019-17.fc38
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-03-14 09:49:41 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Miro Hrončok 2022-01-29 12:13:04 UTC 
The package b43-tools has the following automatic provide:

  python3dist(b43-debug-tools) = 0

It appears that the actual package version was lost during the packaging process. 

In most cases, this is caused by using a Source that misses version information, e.g. A GitHub tarball when the project uses setuptools_scm or pbr. See https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_source_files_from_pypi

This bugzilla was created in a batch, so it does not have information about the exact cause for this package. If you need help figuring out why this happens in this particular package, feel free to ask.
Comment 1 Ben Cotton 2022-02-08 20:26:23 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 36 development cycle.
Changing version to 36.
Comment 2 Miro Hrončok 2023-01-05 15:46:03 UTC 
https://fedoraproject.org/wiki/Changes/Prevent-Providing-python3dist(pkg)=0 has landed and this package will now fail to build in Fedora 38+.

Please, respond to this bugzilla, it has been open for a year.
Comment 3 Pete Walter 2023-03-13 21:38:10 UTC 
I don't know what to do with it. Can you help please? Should I put 'SETUPTOOLS_SCM_PRETEND_VERSION=%{version}' somewhere?

I am not very familiar with the package as I only picked it up to avoid retirement.
Comment 4 Miro Hrončok 2023-03-13 22:28:41 UTC 
Sure thing. Let me see...

------------------------------------------------
$ fedpkg clone b43-tools
$ cd b43-tools
$ fedpkg prep
$ cd b43-tools-019/
$ fd 'setup\.py'
debug/setup.py
$ cat debug/setup.py 
#!/usr/bin/env python
#
# Run this script as root to install the debugging tools
#

from distutils.core import setup
import sys

if len(sys.argv) == 1:
	sys.argv.append("install")	# default to INSTALL

setup(
	name="B43-debug-tools",
	py_modules=["libb43"],
	scripts=["b43-fwdump", "b43-beautifier"]
     )
------------------------------------------------

This setup.py script is missing version entirely. Let's hack some version in:

------------------------------------------------
$ git diff
diff --git a/b43-tools.spec b/b43-tools.spec
index 948f40d..7e11a9c 100644
--- a/b43-tools.spec
+++ b/b43-tools.spec
...
 # For py3_build/py3_install macros
-install -p -m 0644 debug/install.py debug/setup.py
+sed 's/py_modules=/version="%{version}", py_modules=/' debug/install.py > debug/setup.py
------------------------------------------------
$ fedpkg mockbuild
...
Provides: b43-tools = 019-16.fc39 b43-tools(x86-64) = 019-16.fc39 python3.11dist(b43-debug-tools) = 19 python3dist(b43-debug-tools) = 19
...
------------------------------------------------


That should make it build but it's not nice. You might prefer a patch or similar. Note that distutils is deprecated so this setup.py script will need upstream changes anyway if they want to support Python 3.12+.
Comment 5 Pete Walter 2023-03-14 09:21:13 UTC 
Thank you! I had no idea where to even look.

I'll go ahead and use the sed hack for now and perhaps we need to drop this entirely when Python 3.12 lands in Fedora.
Comment 6 Fedora Update System 2023-03-14 09:46:37 UTC 
FEDORA-2023-e48c084d77 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-e48c084d77
Comment 7 Fedora Update System 2023-03-14 09:49:41 UTC 
FEDORA-2023-e48c084d77 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 8 Fedora Update System 2023-03-14 09:56:25 UTC 
FEDORA-2023-e2059d8df7 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-e2059d8df7
Comment 9 Fedora Update System 2023-03-15 01:49:07 UTC 
FEDORA-2023-e2059d8df7 has been pushed to the Fedora 38 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-e2059d8df7

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 10 Fedora Update System 2023-03-23 00:15:58 UTC 
FEDORA-2023-e2059d8df7 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.