Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 218844

Summary:	Review Request: python-yadis - Relying party support for the Yadis service discovery protocol
Product:	[Fedora] Fedora	Reporter:	Jeffrey C. Ollie <jeff>
Component:	Package Review	Assignee:	John Mahowald <jpmahowald>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	bjohnson
Target Milestone:	---	Flags:	kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-01-14 23:59:33 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	218831, 218839
Bug Blocks:	163779, 218852

Description Jeffrey C. Ollie 2006-12-07 20:25:22 UTC

Spec URL: http://repo.ocjtech.us/misc/fedora/6/SRPMS/python-yadis-1.0.1-1.fc6.spec
SRPM URL: http://repo.ocjtech.us/misc/fedora/6/SRPMS/python-yadis-1.0.1-1.fc6.src.rpm
Description:

This code implements relying party support for the Yadis[1] service
discovery protocol.  The protocol was developed for use by
decentralized URL-based identity systems, but is useful for
advertising services provided by or on behalf of a certain URL.

To learn more about Yadis, see http://www.openidenabled.com/yadis

The JanRain Python OpenID library[2] uses this library for discovery
of OpenID service endpoints.  See that library for an example of
library usage.

1. http://yadis.org/
2. http://www.openidenabled.com/openid/libraries/python/

Comment 1 Bernard Johnson 2006-12-09 22:31:35 UTC

This is an unofficial review as I'm not sponsored.

rpmlint is silent on srpm.

Package mock-builds for FC6

A license file is not included with the distribution - please query upstream for
inclusion.

All "Must" requirements met.

Nice packaging.  This ends my review.

Comment 2 John Mahowald 2007-01-06 07:19:52 UTC

Fix:
- Links broken in doc/apache-config.html, linked examples were moved to
examples/apache

Would be nice:
- I see version 1.1.0 at http://www.openidenabled.com/yadis/libraries/python

Comment 3 Jeffrey C. Ollie 2007-01-13 18:36:42 UTC

Spec URL: http://repo.ocjtech.us/misc/fedora/6/SRPMS/python-yadis-1.1.0-1.fc6.spec
SRPM URL:
http://repo.ocjtech.us/misc/fedora/6/SRPMS/python-yadis-1.1.0-1.fc6.src.rpm

Updated to 1.1.0

Comment 4 John Mahowald 2007-01-13 20:35:55 UTC

Packaging note from the README:
This is the last release of python-yadis as an independently
distributed package.  Future versions will come bundled with the
python-openid library.

Review:
+ License (LGPL)
+ noarch package, installs to %{python_sitelib}
+ follows python template
+ source matches upstream
+ %check passed
+ use of macros
+ follows naming guidelines
+ rpmlint clean
+ builds on x86_64

APPROVED

Comment 5 Jeffrey C. Ollie 2007-01-14 23:59:04 UTC

Imported and built on development after I fixed some issues with python 2.5 and
elementtree.  Branches requested for FC-5 and FC-6

Comment 6 Jeffrey C. Ollie 2007-12-15 01:09:08 UTC

Package Change Request
======================
Package Name: python-yadis
New Branches: EL-4 EL-5
Updated EPEL Owners: jcollie

Comment 7 Kevin Fenzi 2007-12-15 19:09:38 UTC

cvs done.