Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1111954 (kf5-ktexteditor) - Review Request: kf5-ktexteditor - KDE Frameworks 5 Tier 3 with advanced embeddable text editor
Summary: Review Request: kf5-ktexteditor - KDE Frameworks 5 Tier 3 with advanced embed...
Keywords:
Status: CLOSED RAWHIDE
Alias: kf5-ktexteditor
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jan Grulich
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: kf5-kio kf5-kparts
Blocks: kde-reviews kf5
TreeView+ depends on / blocked
 
Reported: 2014-06-22 11:21 UTC by Daniel Vrátil
Modified: 2015-11-02 01:38 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-07-02 15:38:21 UTC
Type: ---
Embargoed:
jgrulich: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Daniel Vrátil 2014-06-22 11:21:11 UTC 
Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-ktexteditor.spec
SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-ktexteditor-4.100.0-1.src.rpm
Description: KTextEditor provides a powerful text editor component that you can embed in your application, either as a KPart or using the KF5::TextEditor library (if you need more control).

The text editor component contains many useful features, from syntax highlighting and automatic indentation to advanced scripting support, making it
suitable for everything from a simple embedded text-file editor to an advanced
IDE.

Fedora Account System Username: dvratil
Comment 1 Jan Grulich 2014-06-27 09:19:17 UTC 
Doesn't build, because it can't find /usr/lib/qt5/plugins/kf5/katepart.so which is installed into /usr/lib/qt5/plugins/katepart.so.
Comment 2 Daniel Vrátil 2014-06-29 11:05:50 UTC 
Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-ktexteditor.spec
SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-ktexteditor-4.100.0-2.src.rpm

Imported an upstream patch to fix installation destination of the katepart.so plugin (it's /usr/lib/qt5/plugins/kf5/parts/ now)
Comment 3 Jan Grulich 2014-07-01 09:35:25 UTC 
1) Missing call of update-desktop-database
2) Missing %config before %{_sysconfdir}/xdg/kate*
3) E: incorrect-fsf-address /usr/share/katepart5/script/indentation/lilypond.js
- this is not a blocking issue, but upstream should be informed about this
Comment 4 Daniel Vrátil 2014-07-01 10:35:48 UTC 
Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-ktexteditor.spec
SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-ktexteditor-4.100.0-3.src.rpm

Added %config and call to update-desktop-database
Comment 5 Jan Grulich 2014-07-01 11:33:28 UTC 
I also forgot to mention that the patch doesn't apply, but I fixed it locally and you can find the fixed patch here [1]. It looks good now, approved.

[1] http://jgrulich.fedorapeople.org/ktexteditor-move-katepart-into-kf5-parts-sudir-of-plugin-dir.patch
Comment 6 Daniel Vrátil 2014-07-02 13:25:05 UTC 
New Package SCM Request
=======================
Package Name: kf5-ktexteditor
Short Description: KDE Frameworks 5 Tier 3 with advanced embeddable text editor
Upstream URL: http://www.kde.org
Owners: dvratil jgrulich ltinkl rdieter kkofler than
Branches: 
InitialCC:
Comment 7 Gwyn Ciesla 2014-07-02 13:43:33 UTC 
Git done (by process-git-requests).
Comment 8 Daniel Vrátil 2014-09-25 09:04:53 UTC 
Package Change Request
=======================
Package Name: kf5-ktexteditor
New Branches: f20
Owners: dvratil ltinkl jgrulich kkofler rdieter than
Comment 9 Gwyn Ciesla 2014-09-25 13:05:45 UTC 
Git done (by process-git-requests).
Note You need to log in before you can comment on or make changes to this bug.