Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1111948 (kf5-kio) - Review Request: kf5-kio - KDE Frameworks 5 Tier 3 solution for filesystem abstraction
Summary: Review Request: kf5-kio - KDE Frameworks 5 Tier 3 solution for filesystem abs...
Keywords:
Status: CLOSED RAWHIDE
Alias: kf5-kio
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jan Grulich
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: kf5-kconfigwidgets kf5-kservice kf5-knotifications kf5-kxmlgui kf5-kbookmarks kf5-kwallet
Blocks: kde-reviews kf5 kf5-kdeclarative kf5-kparts kf5-ktexteditor kf5-kdewebkit kf5-kinit kf5-knotifyconfig kf5-kross kf5-knewstuff kf5-kactivities kf5-plasma kf5-frameworkintegration kf5-kdelibs4support kf5-khtml
TreeView+ depends on / blocked
 
Reported: 2014-06-22 11:06 UTC by Daniel Vrátil
Modified: 2015-11-02 01:38 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-07-02 14:02:03 UTC
Type: ---
Embargoed:
jgrulich: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Daniel Vrátil 2014-06-22 11:06:03 UTC 
Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kio.spec
SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kio-4.100.0-1.fc20.src.rpm
Description: KDE Frameworks 5 Tier 3 solution for resource and network access abstraction.
Fedora Account System Username: dvratil
Comment 1 Lukáš Tinkl 2014-06-24 17:50:39 UTC 
Build fails with:

/builddir/build/BUILD/kio-4.100.0/src/core/dataprotocol.cpp: In member function 'virtual void KIO::DataProtocol::get(const QUrl&)':
/builddir/build/BUILD/kio-4.100.0/src/core/dataprotocol.cpp:280:89: error: no matching function for call to 'QString::toLatin1() const'
         QTextCodec *codec = QTextCodec::codecForName(hdr.attributes["charset"].toLatin1());
                                                                                         ^
/builddir/build/BUILD/kio-4.100.0/src/core/dataprotocol.cpp:280:89: note: candidates are:
In file included from /usr/include/qt5/QtCore/QString:1:0,
                 from /builddir/build/BUILD/kio-4.100.0/src/core/global.h:23,
                 from /builddir/build/BUILD/kio-4.100.0/src/core/dataslave_p.h:25,
                 from /builddir/build/BUILD/kio-4.100.0/src/core/dataprotocol_p.h:49,
                 from /builddir/build/BUILD/kio-4.100.0/src/core/dataprotocol.cpp:19:
/usr/include/qt5/QtCore/qstring.h:465:16: note: QByteArray QString::toLatin1() const &
     QByteArray toLatin1() const & Q_REQUIRED_RESULT
                ^
/usr/include/qt5/QtCore/qstring.h:465:16: note:   no known conversion for implicit 'this' parameter from 'const QString' to 'const QString&'
/usr/include/qt5/QtCore/qstring.h:467:16: note: QByteArray QString::toLatin1() &&
     QByteArray toLatin1() && Q_REQUIRED_RESULT
                ^
/usr/include/qt5/QtCore/qstring.h:467:16: note:   no known conversion for implicit 'this' parameter from 'const QString' to 'QString&&'
src/core/CMakeFiles/KF5KIOCore.dir/build.make:725: recipe for target 'src/core/CMakeFiles/KF5KIOCore.dir/dataprotocol.cpp.o' failed
make[2]: *** [src/core/CMakeFiles/KF5KIOCore.dir/dataprotocol.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/builddir/build/BUILD/kio-4.100.0/i686-redhat-linux-gnu'
CMakeFiles/Makefile2:3743: recipe for target 'src/core/CMakeFiles/KF5KIOCore.dir/all' failed
make[1]: *** [src/core/CMakeFiles/KF5KIOCore.dir/all] Error 2
make[1]: Leaving directory '/builddir/build/BUILD/kio-4.100.0/i686-redhat-linux-gnu'
Makefile:120: recipe for target 'all' failed
make: Leaving directory '/builddir/build/BUILD/kio-4.100.0/i686-redhat-linux-gnu'
make: *** [all] Error 2
Comment 2 Daniel Vrátil 2014-06-25 09:16:27 UTC 
Builds just fine here and in Copr and the error itself does not make much sense to me. Maybe there's something wrong with your Qt 5 setup or environment?
Comment 3 Jan Grulich 2014-06-27 07:40:00 UTC 
I hit the same problem when I was building qt5-qtbase in rawhide, it was an issue in gcc and it worked later with a newer build. I'll finish the review since Lukáš is on PTO.
Comment 4 Jan Grulich 2014-06-27 08:15:27 UTC 
1) License - some files are also under GPLv2+, BSD and MIT licenses.
2) Missing call of update-desktop-database, because of a desktop file with a Mimetype entry.
3) Missing %config before files installed to /etc/xdg
Comment 5 Daniel Vrátil 2014-06-28 11:41:05 UTC 
Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kio.spec
SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kio-4.100.0-2.fc20.src.rpm

- fixed licenses
- added %%config
- added update-desktop-database
Comment 6 Jan Grulich 2014-07-01 07:54:11 UTC 
It's not necessary to have Requires: kf5-kwallet-libs, just remove it during import. The rest looks good, approved.
Comment 7 Daniel Vrátil 2014-07-01 10:26:45 UTC 
New Package SCM Request
=======================
Package Name: kf5-kio
Short Description: KDE Frameworks 5 Tier 3 solution for filesystem abstraction
Upstream URL: http://www.kde.org
Owners: dvratil jgrulich ltinkl kkofler rdieter than
Branches: 
InitialCC:
Comment 8 Gwyn Ciesla 2014-07-01 12:06:24 UTC 
Git done (by process-git-requests).
Comment 9 Daniel Vrátil 2014-09-25 09:03:17 UTC 
Package Change Request
=======================
Package Name: kf5-kio
New Branches: f20
Owners: dvratil ltinkl jgrulich kkofler rdieter than
Comment 10 Gwyn Ciesla 2014-09-25 13:02:14 UTC 
Git done (by process-git-requests).
Note You need to log in before you can comment on or make changes to this bug.