Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1111957 (kf5-kinit) - Review Request: kf5-kinit - KDE Frameworks 5 tier 3 solution for process launching
Summary: Review Request: kf5-kinit - KDE Frameworks 5 tier 3 solution for process laun...
Keywords:
Status: CLOSED RAWHIDE
Alias: kf5-kinit
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jan Grulich
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: kf5-kservice kf5-kio
Blocks: kde-reviews kf5 kf5-kded
TreeView+ depends on / blocked
 
Reported: 2014-06-22 11:28 UTC by Daniel Vrátil
Modified: 2015-11-02 01:38 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-07-02 15:05:53 UTC
Type: ---
Embargoed:
jgrulich: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Daniel Vrátil 2014-06-22 11:28:30 UTC 
Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kinit.spec
SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kinit-4.100.0-1.fc20.src.rpm
Description: kdeinit is a process launcher somewhat similar to the famous init used for booting UNIX.

It launches processes by forking and then loading a dynamic library which should contain a 'kdemain(...)' function.

Fedora Account System Username: dvratil
Comment 1 Jan Grulich 2014-06-27 10:56:28 UTC 
1) License - src/kdeinit/proctitle.{h,cpp} are under BSD license.
2) Shouldn't be libkdeinit5_klauncher.so in -devel subpackage? If not, then the library should be versioned.
3) Rpmlint error - kf5-kinit.i686: E: missing-call-to-setgroups /usr/libexec/kf5/start_kdeinit - this is the same issue which was present in kf5-kcrash, it's not a blocking issue, but should be reported and fixed in upstream.
Comment 2 Daniel Vrátil 2014-06-29 10:50:18 UTC 
Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kinit.spec
SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kinit-4.100.0-2.fc20.src.rpm

> 1) License - src/kdeinit/proctitle.{h,cpp} are under BSD license.

Fixed

> 2) Shouldn't be libkdeinit5_klauncher.so in -devel subpackage? If not, then the > library should be versioned.

Nope, it's technically a plugin, see for instance /usr/lib(64)/libkdeinit_*.

> 3) Rpmlint error - kf5-kinit.i686: E: missing-call-to-setgroups /usr/libexec
> /kf5/start_kdeinit - this is the same issue which was present in kf5-kcrash, 
> it's not a blocking issue, but should be reported and fixed in upstream.

Submitted patch to upstream (https://git.reviewboard.kde.org/r/119011/)
Comment 3 Jan Grulich 2014-07-01 09:02:08 UTC 
Ok, looks good now, approved.
Comment 4 Daniel Vrátil 2014-07-01 10:30:03 UTC 
New Package SCM Request
=======================
Package Name: kf5-kinit
Short Description: KDE Frameworks 5 tier 3 solution for process launching
Upstream URL: http://www.kde.org
Owners: dvratil jgrulich ltinkl rdieter kkofler than
Branches: 
InitialCC:
Comment 5 Gwyn Ciesla 2014-07-01 12:10:15 UTC 
Git done (by process-git-requests).
Comment 6 Daniel Vrátil 2014-09-25 09:03:07 UTC 
Package Change Request
=======================
Package Name: kf5-kinit
New Branches: f20
Owners: dvratil ltinkl jgrulich kkofler rdieter than
Comment 7 Gwyn Ciesla 2014-09-25 13:06:43 UTC 
Git done (by process-git-requests).
Note You need to log in before you can comment on or make changes to this bug.