Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1424233 - Review Request: GNOME Internet Radio Locator - Locate Internet Radio Stations
Summary: Review Request: GNOME Internet Radio Locator - Locate Internet Radio Stations
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-NEEDSPONSOR
TreeView+ depends on / blocked
 
Reported: 2017-02-17 16:24 UTC by Ole Aamot
Modified: 2017-11-29 13:59 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-11-29 13:59:23 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Ole Aamot 2017-02-17 16:24:14 UTC 
Spec URL: https://people.gnome.org/~ole/girl/girl.spec
SRPM URL: https://people.gnome.org/~ole/girl/girl-9.8.0-1.fc25.src.rpm
Description: Locate Internet Radio Stations
Fedora Account System Username: oka
Comment 1 ole 2017-05-07 17:27:09 UTC 
I've updated the package to 10.0.0 which is based on gstreamer for playback of the included 86 Internet Radio stations.

Spec URL: https://people.gnome.org/~ole/girl/girl.spec
SRPM URL: https://people.gnome.org/~ole/girl/girl-10.0.0-1.fc25.src.rpm
Description: Locate Internet Radio Stations
Fedora Account System Username: oka

See https://wiki.gnome.org/Apps/Girl and https://people.gnome.org/~ole/girl/

I would like to see GNOME Internet Radio Locator included in Fedora Rawhide
after December 31, 2017 when the Frauenhofer MP3 patents expire.

Best,
Ole
Comment 2 ole 2017-05-07 17:33:09 UTC 
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=19435876
Comment 3 c72578 2017-08-03 15:11:57 UTC 
Hello Ole,
here are some comments:

- Please remove "Applications/Internet" from spec file, which is deprecated
https://fedoraproject.org/wiki/RPMGroups

- Source: could be changed from
http://people.gnome.org/~ole/%{name}/%{name}-%{version}.tar.xz
to
https://download.gnome.org/sources/%(name)/10.0/%{name}-%{version}.tar.xz

Because the girl git repo is also at the gnome site: https://git.gnome.org/browse/girl/

- Concerning the changelog entries:
The dist should not be added after the version in the changelog and the e-mail address is usually included according to Fedora guidelines.
https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs
e.g.:
* Thu May 04 2017 Ole Aamot - 10.0.0-1.fc25
->
* Thu May 04 2017 Ole Aamot <oka> - 10.0.0-1

Best regards
Wolfgang
Comment 4 Ole Aamot 2017-08-04 21:26:21 UTC 
Spec URL: https://people.gnome.org/~ole/girl/girl.spec
SRPM URL: https://people.gnome.org/~ole/girl/girl-10.0.0-2.fc26.src.rpm
Description: Locate Internet Radio Stations
Fedora Account System Username: oka
Comment 5 leigh scott 2017-08-11 17:26:09 UTC 
A couple of issues

1. This

Requires:       gstreamer1-plugins-ugly >= 1.8.3

should be

Requires:       gstreamer1-plugins-ugly-free >= 1.8.3

as your not allowed to require a rpmfusion package


2. Remove the obsolete scriptlets for mime

/usr/bin/update-desktop-database &> /dev/null || :

https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#desktop-database
Comment 6 Ole Aamot 2017-08-12 18:09:27 UTC 
Spec URL: https://people.gnome.org/~ole/girl/girl.spec
SRPM URL: https://people.gnome.org/~ole/girl/girl-10.0.0-3.fc26.src.rpm
Description: Locate Internet Radio Stations
Fedora Account System Username: oka
Fedora f26-candidate koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=21191960
Comment 7 leigh scott 2017-08-12 19:02:20 UTC 
You missed one of the mime scriptlets


/usr/bin/update-desktop-database &> /dev/null || :
Comment 8 Ole Aamot 2017-08-12 19:43:03 UTC 
Spec URL: https://people.gnome.org/~ole/girl/girl.spec
SRPM URL: https://people.gnome.org/~ole/girl/girl-10.0.0-4.fc26.src.rpm
Description: Locate Internet Radio Stations
Fedora Account System Username: oka
Fedora f26-candidate koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=21194234
Comment 9 Ole Aamot 2017-11-29 13:59:23 UTC 
Obsolete package.  See bug #1517451
Note You need to log in before you can comment on or make changes to this bug.