Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 169471 - Review Request: gtk-gnutella - GUI based Gnutella Client
Summary: Review Request: gtk-gnutella - GUI based Gnutella Client
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Aurelien Bompard
QA Contact: David Lawrence
URL: http://gtk-gnutella.sourceforge.net
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2005-09-28 17:04 UTC by Dmitry Butskoy
Modified: 2012-02-13 14:48 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2005-10-05 12:08:42 UTC
Type: ---
Embargoed:
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Dmitry Butskoy 2005-09-28 17:04:40 UTC 
Spec Url: http://dmitry.butskoy.name/gtk-gnutella/gtk-gnutella.spec
SRPM Url: http://dmitry.butskoy.name/gtk-gnutella/gtk-gnutella-0.95.4-1.src.rpm

Description: 
Gtk-Gnutella is a GUI based Gnutella p2p servent. It's a fully featured
servent designed to share any type of file.  Gtk-gnutella implements
compressed gnutella net connections, ultrapeer and leaf nodes and uses
Passive/Active Remote Queueing (PARQ), and other modern gnutella network
features.
Comment 1 Aurelien Bompard 2005-10-02 21:45:12 UTC 
Needs work:
* No downloadable source. Please give the full URL in the Source tag.
* rpmlint of gtk-gnutella: non-standard-executable-perm /usr/bin/gtk-gnutella 0555

P2P software is not included in ForbiddenItems (and is not illegal in itself
actually), but I'd like to get clearance from Legal (as asked in bug 169604)
Comment 2 Dmitry Butskoy 2005-10-03 11:49:11 UTC 
I already asked about it a little, see
https://www.redhat.com/archives/fedora-extras-list/2005-September/msg01571.html
Comment 3 Dmitry Butskoy 2005-10-03 12:24:36 UTC 
Source and exec-perms: done.
Comment 4 Aurelien Bompard 2005-10-03 14:08:55 UTC 
I've had a look at the included URLs in gwcache.boot, and none contain obvious
illegal material.

Review for release 1:
* RPM name is OK
* Source gtk-gnutella-0.95.4.tar.bz2 is the same as upstream
* This is the latest version
* Builds fine in mock
* rpmlint of gtk-gnutella looks OK
* File list of gtk-gnutella looks OK
* Works fine.
APPROVED
Comment 5 Michael Schwendt 2005-10-03 15:57:15 UTC 
How did you check GWebCache contents? I believe it is impossible to
ensure that they do not reference any servents with illegal content.
IMO, it would be better no just ship the software and not any
bootstrapping URLs.
Comment 6 Aurelien Bompard 2005-10-03 16:09:52 UTC 
> How did you check GWebCache contents ?

I just opened the URLs in a browser and had a very quick look at them. But if
gtk-gnutella can work without the gwcache.boot file, it would be better to
remove it, I agree
Comment 7 Dmitry Butskoy 2005-10-03 16:38:59 UTC 
/usr/share/gtk-gnutella/gwcache.boot actually points to some http urls. It does
not point directly to any servents with contents. These urls are not intended
for any content providing. I believe that Gnutella knows all the legal issues
and avoids them...

IMHO, some similar situation was "links to fedorafaq.org site", which I saw
recently somewhere in mailing lists. Fedora can points to "fedorafaq" site, just
saying nothing particularly about what the users can find there. (They can find
there links to soft with legal issues).

May be I should just check carefully all the gwcache.boot links (and do it on
each package update)? But, IMHO, upstream already should do it...

Anyway, without initial gwcache, the program appears to be much less usable.
Comment 8 Dmitry Butskoy 2005-10-04 10:48:20 UTC 
I've checked out it once again, for me nothing illegal at the urls specified.

Yes, they indirectly specify some servents, but it is "dynamic" data (who is
currently run etc.), therefore we cannot check them in general. And I believe
the presumption of innocence operates in this context...


Aurelien, Michael,

some more doubts?
Comment 9 Dmitry Butskoy 2005-10-05 12:08:42 UTC 
Aurelien,

I've already committed and built gtk-gnutella before you had reopened this
bugzilla ticket. Now it has appeared at the download site. Therefore I close
here again.

If any doubts will appear later, open a new bugzilla ticket for this package
usual way.
Comment 10 Dmitry Butskoy 2005-10-06 10:22:49 UTC 
...and upstream's comment here:
http://sourceforge.net/mailarchive/forum.php?thread_id=8422691&forum_id=5942
Comment 11 Dmitry Butskoy 2012-02-13 12:05:16 UTC 
Package Change Request
======================
Package Name: gtk-gnutella
New Branches: el6
Owners: buc
Comment 12 Gwyn Ciesla 2012-02-13 14:48:29 UTC 
Git done (by process-git-requests).
Note You need to log in before you can comment on or make changes to this bug.