Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 169604 - Review Request: dclib - Direct Connect file sharing library
Summary: Review Request: dclib - Direct Connect file sharing library
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Aurelien Bompard
QA Contact: David Lawrence
Depends On:
Blocks: FE-ACCEPT 169605
TreeView+ depends on / blocked
Reported: 2005-09-30 06:43 UTC by Luke Macken
Modified: 2016-09-20 02:36 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2005-10-03 16:02:57 UTC
Type: ---

Attachments (Terms of Use)

Description Luke Macken 2005-09-30 06:43:09 UTC
Spec Name or Url:
SRPM Name or Url:
Description: This library implements the Direct Connect file sharing protocol.

Comment 1 Brian Pepple 2005-09-30 13:21:22 UTC
This is already a part of the Livna repository.  I can't remember what the
rationale was for not adding it to Extras, but I'll see if I can Google an
answer for that later today.

Comment 2 Aurelien Bompard 2005-10-02 21:08:29 UTC
Needs work:
* The package should contain the text of the license, in the COPYING and 
  COPYING.OpenSSL files  (wiki: PackageReviewGuidelines)
* Each %files section should have a %defattr line (for -devel package)
  (wiki: PackageReviewGuidelines)
* Requires for -devel is wrong, it should be : %{name} = %{version}
* Please include the usual documentation files (README, AUTHORS, ChangeLog, NEWS,

I'd like to know if P2P software is OK for Fedora. Can somebody contact the
legal dpt ?

Comment 3 Luke Macken 2005-10-02 22:15:49 UTC
Wow, stupid mistakes.. I blame lack of sleep :(

These should be fixed. (made Requires: %{name} = %{version}-%{release} to remain
consistent with previous packages (if this is wrong, then I can change it))

Comment 4 Aurelien Bompard 2005-10-03 14:26:49 UTC
Looks like P2P software is OK:

Review for release 2:
* RPM name is OK
* Source dclib-0.3.7.tar.gz is the same as upstream
* Builds fine in mock
* rpmlint of dclib looks OK
* rpmlint of dclib-devel looks OK
* File list of dclib looks OK
* File list of dclib-devel looks OK
* Works fine (tested with valknut)

Comment 5 Luke Macken 2005-10-03 16:02:57 UTC
Imported into CVS, updated owners.list file, requested FC-3 and FC-4 CVS
branches, and built for devel.  Thanks!

Comment 6 Ville Skyttä 2005-10-03 18:53:18 UTC
dclib-devel should probably have "Requires: libxml2-devel", 
see /usr/include/dclib/cconfig.h 

Comment 7 Luke Macken 2005-10-03 19:12:44 UTC
(In reply to comment #6)
> dclib-devel should probably have "Requires: libxml2-devel", 
> see /usr/include/dclib/cconfig.h 

fixed, thanks.

Comment 8 Ville Skyttä 2005-10-03 19:17:14 UTC
(In reply to comment #7) 
> fixed, thanks. 
Not quite, it should be in dclib-devel, not dclib... 

Comment 9 Luke Macken 2005-10-03 19:25:53 UTC
Oops, my bad.  Fixed.

Note You need to log in before you can comment on or make changes to this bug.