Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 169605 - Review Request: valknut - A Direct Connect client
Summary: Review Request: valknut - A Direct Connect client
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Aurelien Bompard
QA Contact: David Lawrence
URL: http://dcgui.berlios.de
Whiteboard:
Depends On: 169604
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2005-09-30 06:44 UTC by Luke Macken
Modified: 2016-09-20 02:36 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2005-10-04 21:41:23 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Luke Macken 2005-09-30 06:44:42 UTC 
Spec Name or Url: http://people.redhat.com/lmacken/valknut.spec
SRPM Name or Url: http://people.redhat.com/lmacken/valknut-0.3.7-1.src.rpm
Description:
Valknut is a program the uses the Direct Connect protocol. It is compatible
with other DC clients, such as the original DC from Neomodus, DC++ and
derivatives. Valknut also interoperates with all common DC hub software.
Comment 1 Brian Pepple 2005-09-30 13:22:09 UTC 
This is also in the Livna repository, but seems not to have been rebuilt for FC4.
Comment 2 Aurelien Bompard 2005-10-03 07:26:26 UTC 
* BuildRequires: desktop-file-utils is missing
* You could replace "--with-qt-dir" with QT environment variable, so you don't 
  have to update it when QT4 is out. Usually, it's:
    unset QTDIR && . %{_sysconfdir}/profile.d/qt.sh
  and then %configure
* Please use install -p to preserve timestamps
* desktop file already contains X-Fedora
Comment 3 Luke Macken 2005-10-03 15:36:17 UTC 
(In reply to comment #2)
> * BuildRequires: desktop-file-utils is missing
> * You could replace "--with-qt-dir" with QT environment variable, so you don't 
>   have to update it when QT4 is out. Usually, it's:
>     unset QTDIR && . %{_sysconfdir}/profile.d/qt.sh
>   and then %configure
> * Please use install -p to preserve timestamps
> * desktop file already contains X-Fedora

Fixed.

http://people.redhat.com/lmacken/valknut.spec
http://people.redhat.com/lmacken/valknut-0.3.7-2.src.rpm
Comment 4 Aurelien Bompard 2005-10-03 16:11:01 UTC 
Missing BuildRequires : libxml-devel (build fails in mock)
Comment 5 Luke Macken 2005-10-04 01:14:08 UTC 
This was an issue with dclib-devel not pulling down libxml2-devel, which should
be fixed now.  I also added bzip2-devel to BuildRequires for valknut.. builds
fine in mock now.

http://people.redhat.com/lmacken/valknut.spec
http://people.redhat.com/lmacken/valknut-0.3.7-3.src.rpm
Comment 6 Aurelien Bompard 2005-10-04 11:14:55 UTC 
Missing BuildRequires: openssl-devel
Curiously, it builds without it, but segfaults on startup.
Comment 7 Luke Macken 2005-10-04 15:22:39 UTC 
(In reply to comment #6)
> Missing BuildRequires: openssl-devel
> Curiously, it builds without it, but segfaults on startup.

Added.

http://people.redhat.com/lmacken/valknut-0.3.7-3.src.rpm
Comment 8 Luke Macken 2005-10-04 15:23:08 UTC 
ermm.. wrong url..

http://people.redhat.com/lmacken/valknut-0.3.7-4.src.rpm
Comment 9 Aurelien Bompard 2005-10-04 16:27:40 UTC 
Review for release 4:
* RPM name is OK
* Source valknut-0.3.7.tar.gz is the same as upstream
* Builds fine in mock
* rpmlint of valknut looks OK
* File list of valknut looks OK
* Works as expected
APPROVED
Comment 10 Luke Macken 2005-10-04 21:41:23 UTC 
Imported into CVS, added to owners.list, requested branches for FC-3/FC-4, and
built for devel.  Thanks!
Note You need to log in before you can comment on or make changes to this bug.