Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 186887 - Review Request: libnetfilter_conntrack - Netfilter conntrack userspace library
Summary: Review Request: libnetfilter_conntrack - Netfilter conntrack userspace library
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Kevin Fenzi
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On: 186811
Blocks: FE-ACCEPT 186892
TreeView+ depends on / blocked
 
Reported: 2006-03-27 08:59 UTC by Paul P Komkoff Jr
Modified: 2012-12-04 13:36 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-05-14 16:48:48 UTC
Type: ---
Embargoed:
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Paul P Komkoff Jr 2006-03-27 08:59:45 UTC 
Spec Name or Url: http://stingr.net/l/fe/libnetfilter_conntrack.spec
SRPM Name or Url: http://stingr.net/l/fe/libnetfilter_conntrack-0.0.30-1.src.rpm
Description:
libnetfilter_conntrack is a userspace library providing a programming
interface (API) to the in-kernel connection tracking state table.

P.S. This BuildRequires libnfnetlink which is on review too, I've put all these built in mock here: http://proxy.sgu.ru/mock/4/x86_64/
Comment 1 Paul P Komkoff Jr 2006-05-08 20:26:18 UTC 
http://stingr.net/l/fe/libnetfilter_conntrack.spec
http://stingr.net/l/fe/libnetfilter_conntrack-0.0.30-2.src.rpm
Comment 2 Stefan Neufeind 2006-05-11 13:57:52 UTC 
Since 186811 has been approved now, any objections to this package?
Comment 3 Kevin Fenzi 2006-05-14 01:40:05 UTC 
In answer to comment #2:

Each package must go through a review. ;)

And here is one for this package:

See below - Rpmlint output.
OK - Package name.
OK - Spec file name matches.
OK - Package guidelines.
OK - Licsense.
OK - License field matches in spec.
OK - License included in files
OK - Spec in american english
OK - Spec legible
OK - Md5sum of source from upstream
e07f3d159a869900fbf23f5df12aaf3e  libnetfilter_conntrack-0.0.30.tar.bz2
e07f3d159a869900fbf23f5df12aaf3e  libnetfilter_conntrack-0.0.30.tar.bz2.1

OK - Compiles and builds on one arch at least.
(builds in mock on fc5)
OK - Excludearch not needed
OK - Forbidden buildrequires not included
OK - All required buildrequires included
OK - Ldconfig in post/postun if including libs.
OK - Owns all directories it creates.
OK - No duplicate files in %files listing.
OK - Permissions on files correct.
OK - Clean section correct.
OK - Macros consistant.
OK - Code not content.
OK - Docs must not affect runtime.
OK - Header files/libs in a devel package.
OK - .so files in devel package.
OK - Devel package requires base package.
OK - No .la files.
OK - Doesn't own any files/dirs that are already owned by others.

1. One rpmlint warning:

W: libnetfilter_conntrack-devel summary-not-capitalized netfilter conntrack
userspace library

Suggest: Change the devel summary to "Netfilter conntrack userspace library
development files"

Looks good. If you could fix up the rpmlint warning when you import
into CVS that would be great.

This package is APPROVED.
Don't forget to close this bug when you have imported and built the package.
Comment 4 Paul P Komkoff Jr 2009-10-13 12:24:08 UTC 
Package Change Request
======================
Package Name: libnetfilter_conntrack
New Branches: EL-4 EL-5
Owners: stingray jrussek
Comment 5 Kevin Fenzi 2009-10-15 17:34:04 UTC 
jrussek doesn't seem to be in the packager group. 
Can you get their sponsorship fixed up, or file a new request?
Comment 6 Paul P Komkoff Jr 2012-12-03 22:00:13 UTC 
Package Change Request
======================
Package Name: libnetfilter_conntrack
New Branches: EL-5 EL-6
Owners: stingray
Comment 7 Gwyn Ciesla 2012-12-04 13:36:26 UTC 
Git done (by process-git-requests).
Note You need to log in before you can comment on or make changes to this bug.