Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 186892 - Review Request: conntrack - Tool to manipulate netfilter connection tracking table
Summary: Review Request: conntrack - Tool to manipulate netfilter connection tracking ...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Kevin Fenzi
QA Contact: Fedora Package Reviews List
Depends On: 186811 186887
TreeView+ depends on / blocked
Reported: 2006-03-27 09:02 UTC by Paul P Komkoff Jr
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2006-05-19 18:37:09 UTC
Type: ---

Attachments (Terms of Use)

Description Paul P Komkoff Jr 2006-03-27 09:02:12 UTC
Spec Name or Url:
SRPM Name or Url:
conntrack  is  used to search, list, inspect and maintain the netfilter
connection tracking subsystem of the Linux kernel.
Using conntrack , you can dump a list of all (or a filtered selection  of)
currently  tracked  connections, delete connections from the state table,
and even add new ones.
In  addition,  you  can  also  monitor connection tracking events, e.g.
show an event message (one line) per newly established connection.

P.S. This also BuildRequires libnfnetlink and libnetfilter_conntrack

Comment 2 Stefan Neufeind 2006-05-11 13:57:48 UTC
Since 186811 has been approved now, any objections to this package?

Comment 3 Kevin Fenzi 2006-05-14 01:59:52 UTC

I'm happy to review this package as well.
Before a full review however: 

1. You seem to have updated to the latest upstream version (1.00beta1), but 
didn't increment the version in the spec/src.rpm. Could you generate a new 
spec and src.rpm with the current version in place? 

2. libnfnetlink seems to only be available in devel currently. Do you plan to
add that (and libnetfilter_conntrack and conntrack) to fc5 as well? 

Comment 4 Paul P Komkoff Jr 2006-05-14 19:23:00 UTC
1. I'm not sure that (version = 1.0 and release = beta1) will be less than
(version = 1.0 and release = 1) so I just did what gcc and others do - various
pre- versions are just x.99

2. Of course. After I add this package I'll request it for fc5 and fc4.

Comment 5 Kevin Fenzi 2006-05-14 20:09:08 UTC
In reply to comment #4: 

1. Ah, yeah... take a look at
Which would I think suggest: 
conntrack-1.0-0.1.beta1 ?

Then, the final should be newer than any of the 0.X.beta1 series...
I think that method prevents confusion about just what version is in the package. 

Comment 7 Kevin Fenzi 2006-05-15 22:39:52 UTC
Here's a review:

OK - Rpmlint output. (none)
OK - Package name.
OK - Spec file name matches.
OK - Package guidelines.
OK - License (GPL)
OK - License field matches in spec.
OK - License included in files
OK - Spec in american english
OK - Spec legible
OK - Md5sum of source from upstream
7491f914a9ebce180df88cbef0d994b3  conntrack-1.00beta1.tar.bz2
7491f914a9ebce180df88cbef0d994b3  conntrack-1.00beta1.tar.bz2.1

OK - Compiles and builds on one arch at least.
(builds ok on devel, didn't use mock as not all requires are pushed out)
OK - No Forbidden buildrequires included
OK - All required buildrequires included
OK - Owns all directories it creates.
OK - No duplicate files in %files listing.
OK - Permissions on files correct.
OK - Clean section correct.
OK - Macros consistant.
OK - Code not content.
OK - Docs must not affect runtime.
OK - Doesn't own any files/dirs that are already owned by others.

No blockers I can see... so this package is APPROVED.

Remember to close this bug with NEXTRELEASE once you have imported
and build the package.

Note You need to log in before you can comment on or make changes to this bug.