Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1945914 - dasbus.error.DBusError: 'NoneType' object has no attribute 'upper'
Summary: dasbus.error.DBusError: 'NoneType' object has no attribute 'upper'
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: python-blivet
Version: 34
Hardware: x86_64
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Vojtech Trefny
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: abrt_hash:9d01d56085581d5f049c2c19a5e...
: 1948092 (view as bug list)
Depends On:
Blocks: F34FinalFreezeException
TreeView+ depends on / blocked
 
Reported: 2021-04-02 16:55 UTC by cube00
Modified: 2021-04-16 04:40 UTC (History)
15 users (show)

Fixed In Version: python-blivet-3.3.3-2.fc34
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-04-16 04:40:28 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
File: anaconda-tb (2.15 MB, text/plain)
2021-04-02 16:55 UTC, cube00
no flags Details
File: anaconda.log (26.93 KB, text/plain)
2021-04-02 16:55 UTC, cube00
no flags Details
File: dbus.log (2.99 KB, text/plain)
2021-04-02 16:55 UTC, cube00
no flags Details
File: dnf.librepo.log (3.54 KB, text/plain)
2021-04-02 16:55 UTC, cube00
no flags Details
File: environ (659 bytes, text/plain)
2021-04-02 16:55 UTC, cube00
no flags Details
File: lorax-packages.log (24.12 KB, text/plain)
2021-04-02 16:55 UTC, cube00
no flags Details
File: lsblk_output (2.38 KB, text/plain)
2021-04-02 16:55 UTC, cube00
no flags Details
File: lvm.log (742.66 KB, text/plain)
2021-04-02 16:56 UTC, cube00
no flags Details
File: nmcli_dev_list (1.60 KB, text/plain)
2021-04-02 16:56 UTC, cube00
no flags Details
File: os_info (776 bytes, text/plain)
2021-04-02 16:56 UTC, cube00
no flags Details
File: program.log (9.94 KB, text/plain)
2021-04-02 16:56 UTC, cube00
no flags Details
File: storage.log (315.99 KB, text/plain)
2021-04-02 16:56 UTC, cube00
no flags Details
File: syslog (961.45 KB, text/plain)
2021-04-02 16:56 UTC, cube00
no flags Details
File: packaging.log (11.96 KB, text/plain)
2021-04-02 16:56 UTC, cube00
no flags Details

Description cube00 2021-04-02 16:55:42 UTC
Description of problem:
Tried to click on an existing Fedora installation in the "Manual Partitioning" screen

Version-Release number of selected component:
anaconda-34.24.5

The following was filed automatically by anaconda:
anaconda 34.24.5 exception report
Traceback (most recent call first):
  File "/usr/lib/python3.9/site-packages/dasbus/client/handler.py", line 497, in _handle_method_error
    raise exception from None
  File "/usr/lib/python3.9/site-packages/dasbus/client/handler.py", line 477, in _get_method_reply
    return self._handle_method_error(error)
  File "/usr/lib/python3.9/site-packages/dasbus/client/handler.py", line 444, in _call_method
    return self._get_method_reply(
  File "/usr/lib64/python3.9/site-packages/pyanaconda/ui/gui/spokes/custom_storage.py", line 696, in _setup_fstype_combo
    self._device_tree.GetFormatTypeData(fs_type)
  File "/usr/lib64/python3.9/site-packages/pyanaconda/ui/gui/spokes/custom_storage.py", line 813, in _populate_right_side
    self._setup_fstype_combo(self._request.device_type, self._request.format_type, format_types)
  File "/usr/lib64/python3.9/site-packages/pyanaconda/ui/gui/spokes/custom_storage.py", line 1422, in on_selector_clicked
    self._populate_right_side(self._accordion.current_selector)
  File "/usr/lib64/python3.9/site-packages/pyanaconda/ui/gui/spokes/custom_storage.py", line 1041, in _show_mountpoint
    self.on_selector_clicked(None, page.members[0])
  File "/usr/lib64/python3.9/site-packages/pyanaconda/ui/gui/spokes/custom_storage.py", line 1433, in on_page_clicked
    self._show_mountpoint(page=page, mountpoint=mountpoint_to_show)
  File "/usr/lib64/python3.9/site-packages/pyanaconda/ui/gui/spokes/lib/accordion.py", line 99, in _on_expanded
    cb(child)
dasbus.error.DBusError: 'NoneType' object has no attribute 'upper'

Additional info:
addons:         com_redhat_kdump
cmdline:        /usr/bin/python3  /sbin/anaconda
cmdline_file:   BOOT_IMAGE=vmlinuz initrd=initrd.img inst.stage2=hd:LABEL=Fedora-S-dvd-x86_64-34 rd.live.check quiet
executable:     /sbin/anaconda
hashmarkername: anaconda
hawkey.log:     2021-04-02T16:49:19+0000 INFO === Started libdnf-0.58.0 ===
kernel:         5.11.3-300.fc34.x86_64
product:        Fedora
release:        Fedora release 34 (Thirty Four)
release_type:   pre-release
type:           anaconda
version:        34

Comment 1 cube00 2021-04-02 16:55:49 UTC
Created attachment 1768590 [details]
File: anaconda-tb

Comment 2 cube00 2021-04-02 16:55:51 UTC
Created attachment 1768591 [details]
File: anaconda.log

Comment 3 cube00 2021-04-02 16:55:52 UTC
Created attachment 1768592 [details]
File: dbus.log

Comment 4 cube00 2021-04-02 16:55:54 UTC
Created attachment 1768593 [details]
File: dnf.librepo.log

Comment 5 cube00 2021-04-02 16:55:55 UTC
Created attachment 1768594 [details]
File: environ

Comment 6 cube00 2021-04-02 16:55:56 UTC
Created attachment 1768595 [details]
File: lorax-packages.log

Comment 7 cube00 2021-04-02 16:55:57 UTC
Created attachment 1768596 [details]
File: lsblk_output

Comment 8 cube00 2021-04-02 16:56:00 UTC
Created attachment 1768597 [details]
File: lvm.log

Comment 9 cube00 2021-04-02 16:56:01 UTC
Created attachment 1768598 [details]
File: nmcli_dev_list

Comment 10 cube00 2021-04-02 16:56:03 UTC
Created attachment 1768599 [details]
File: os_info

Comment 11 cube00 2021-04-02 16:56:05 UTC
Created attachment 1768600 [details]
File: program.log

Comment 12 cube00 2021-04-02 16:56:08 UTC
Created attachment 1768601 [details]
File: storage.log

Comment 13 cube00 2021-04-02 16:56:12 UTC
Created attachment 1768602 [details]
File: syslog

Comment 14 cube00 2021-04-02 16:56:13 UTC
Created attachment 1768603 [details]
File: packaging.log

Comment 15 Vendula Poncova 2021-04-06 10:14:27 UTC
From syslog:

16:51:44,476 WARNING org.fedoraproject.Anaconda.Modules.Storage:INFO:blivet:DiskLabel.parted_device returning None
16:51:44,477 WARNING org.fedoraproject.Anaconda.Modules.Storage:WARNING:dasbus.server.handler:The call org.fedoraproject.Anaconda.Modules.Storage.DeviceTree.Viewer.GetFormatTypeData has failed with an exception:
16:51:44,477 WARNING org.fedoraproject.Anaconda.Modules.Storage:Traceback (most recent call last):
16:51:44,477 WARNING org.fedoraproject.Anaconda.Modules.Storage:  File "/usr/lib/python3.9/site-packages/dasbus/server/handler.py", line 418, in _method_callback
16:51:44,477 WARNING org.fedoraproject.Anaconda.Modules.Storage:    result = self._handle_call(
16:51:44,477 WARNING org.fedoraproject.Anaconda.Modules.Storage:  File "/usr/lib/python3.9/site-packages/dasbus/server/handler.py", line 234, in _handle_call
16:51:44,477 WARNING org.fedoraproject.Anaconda.Modules.Storage:    return handler(*parameters)
16:51:44,477 WARNING org.fedoraproject.Anaconda.Modules.Storage:  File "/usr/lib64/python3.9/site-packages/pyanaconda/modules/storage/devicetree/viewer_interface.py", line 89, in GetFormatTypeData
16:51:44,477 WARNING org.fedoraproject.Anaconda.Modules.Storage:    return DeviceFormatData.to_structure(self.implementation.get_format_type_data(name))
16:51:44,477 WARNING org.fedoraproject.Anaconda.Modules.Storage:  File "/usr/lib64/python3.9/site-packages/pyanaconda/modules/storage/devicetree/viewer.py", line 183, in get_format_type_data
16:51:44,477 WARNING org.fedoraproject.Anaconda.Modules.Storage:    return self._get_format_data(fmt)
16:51:44,477 WARNING org.fedoraproject.Anaconda.Modules.Storage:  File "/usr/lib64/python3.9/site-packages/pyanaconda/modules/storage/devicetree/viewer.py", line 195, in _get_format_data
16:51:44,477 WARNING org.fedoraproject.Anaconda.Modules.Storage:    data.description = fmt.name or ""
16:51:44,477 WARNING org.fedoraproject.Anaconda.Modules.Storage:  File "/usr/lib/python3.9/site-packages/blivet/threads.py", line 53, in run_with_lock
16:51:44,477 WARNING org.fedoraproject.Anaconda.Modules.Storage:    return m(*args, **kwargs)
16:51:44,477 WARNING org.fedoraproject.Anaconda.Modules.Storage:  File "/usr/lib/python3.9/site-packages/blivet/formats/disklabel.py", line 322, in name
16:51:44,477 WARNING org.fedoraproject.Anaconda.Modules.Storage:    return _str % {"name": _(self._name), "type": self.label_type.upper()}
16:51:44,477 WARNING org.fedoraproject.Anaconda.Modules.Storage:AttributeError: 'NoneType' object has no attribute 'upper'

It seems to be an issue in the storage configuration library. Reassigning to blivet.

Comment 16 Vojtech Trefny 2021-04-06 13:09:55 UTC
upstream PR: https://github.com/storaged-project/blivet/pull/949

Comment 17 Vojtech Trefny 2021-04-06 14:11:22 UTC
updates image: https://vtrefny.fedorapeople.org/img/rhbz1945914.img

To reproduce this from the installer, you need a logical volume with a GPT partition table. After that, selecting the LV in the custom spoke causes the crash.

Comment 18 Fedora Blocker Bugs Application 2021-04-06 14:20:16 UTC
Proposed as a Freeze Exception for 34-final by Fedora user vtrefny using the blocker tracking app because:

 This requires a relatively unusual setup to trigger (logical volume with a partition table) but it crashes the installer just by clicking the LV in the custom spoke so it's not possible to avoid when trying to remove or reuse the LV. The fix is very simple and contained so this should be safe to fix even during the final freeze.

Comment 19 Adam Williamson 2021-04-07 23:33:30 UTC
+3 in https://pagure.io/fedora-qa/blocker-review/issue/324 , marking accepted.

Comment 20 Fedora Update System 2021-04-12 11:56:20 UTC
FEDORA-2021-98bb650e3f has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-98bb650e3f

Comment 21 Fedora Update System 2021-04-12 15:10:13 UTC
FEDORA-2021-98bb650e3f has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-98bb650e3f`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-98bb650e3f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 22 Chris Murphy 2021-04-12 17:18:19 UTC
*** Bug 1948092 has been marked as a duplicate of this bug. ***

Comment 23 Chris Murphy 2021-04-14 18:55:43 UTC
Inherited blocker proposal from the closed dup. Removing.

Comment 24 Fedora Update System 2021-04-16 04:40:28 UTC
FEDORA-2021-98bb650e3f has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.