Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 199833 - Review Request: vips - image processing library
Summary: Review Request: vips - image processing library
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jochen Schmitt
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT 199834
TreeView+ depends on / blocked
 
Reported: 2006-07-23 02:41 UTC by Adam Goode
Modified: 2020-01-23 13:32 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-07-28 02:14:23 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Adam Goode 2006-07-23 02:41:14 UTC 
Spec URL: http://www.spicenitz.org/fedora/vips.spec
SRPM URL: http://www.spicenitz.org/fedora/vips-7.10.20-1.src.rpm
Description: VIPS is an image processing library. It is good for very large images
(even larger than the amount of RAM in your machine), and for working
with color.
Comment 1 Jochen Schmitt 2006-07-24 15:56:48 UTC 
Good:
+ Source tar ball match to upstream.
+ rpmlint on source rpm quite.
+ Local build works fine.
+ rpmlint on binary rpms quite.
+ Mock build works fine.


Bad:
- Duplicates BRs: 
   pkgconfig (by lcms-devel), 
   zlib-devel (by libpng-devel), 
   libjpeg-devel (by ImageMagick-devel), 
   lcms-devel (by ImageMagick-devel), 
   libtiff-devel (by ImageMagick-devel), 
   glib2-devel (by pango-devel)
- rpmlint vips complaints weak refs:
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4
g_thread_use_default_impl
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4
g_threads_got_initialized
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4
g_thread_functions_for_glib_use
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_matinv
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_log_imask
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_create_imask
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_rotate_dmask90
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_matcat
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_read_imask
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_create_dmask
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_mask2vips
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_gauss_imask
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_gauss_dmask
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_free
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_matmul
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_printdesc
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_snprintf
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4
im_col_make_tables_RGB
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_free_dmask
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_dup_dmask
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_allocate_vargv
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_initdesc
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_open
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_scale_dmask
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_read_dmask
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_col_display_name
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_image
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_dup_imask
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_close
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_incheck
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_rotate_dmask45
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_free_imask
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_find_function
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_malloc
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4
g_static_mutex_get_mutex_impl
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_error_clear
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_free_vargv
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_log_dmask
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_error_buffer
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_mattrn
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_col_displays
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_copy
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_rotate_imask90
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_rotate_imask45
W: vips undefined-non-weak-symbol /usr/lib/libvipsCC.so.10.8.4 im_setupout
Comment 2 Adam Goode 2006-07-26 02:55:53 UTC 
New version:

http://www.spicenitz.org/fedora/vips.spec
http://www.spicenitz.org/fedora/vips-7.10.20-2.src.rpm

Change: eliminate undefined symbols in libvipsCC.


I have not yet removed the BuildRequires as you suggested. This is because vips
independently requires each of those libraries to build-- for example, vips
still needs glib2-devel to build independently of pango-devel. If pango-devel
were ever to stop requiring glib2-devel (say it switched to glib3-devel), then
vips would fail to have glib2-devel present for it to compile.

Same with the other build requirements, vips independently uses libtiff,
libjpeg, etc. along with ImageMagick.

I can still remove these BuildRequires, since vips will correctly build today
without them. But I'm worried that this could cause the build to fail in
non-obvious ways in the future. For that reason, I request to leave them in.
Comment 3 Jochen Schmitt 2006-07-26 20:25:15 UTC 
It's looks good.

Your package is APPROVED !!!
Comment 4 Adam Goode 2006-07-28 02:14:23 UTC 
Built successfully on devel and FC-5. Still working on building for FC-4, but
closing this bug since it's building on FC-5.
Comment 5 Artem 2020-01-23 13:32:36 UTC 
*** Bug 1794178 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.