Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 212885 (pear-HTTP-Request) - Review Request: php-pear-HTTP-Request - Provides an easy way to perform HTTP requests
Summary: Review Request: php-pear-HTTP-Request - Provides an easy way to perform HTTP ...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: pear-HTTP-Request
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Remi Collet
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On: php-pear-Net-URL
Blocks: FE-ACCEPT pear-Test-Selenium php-pear-SOAP php-pear-Cache
TreeView+ depends on / blocked
 
Reported: 2006-10-29 22:52 UTC by Christopher Stone
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-11-08 00:59:30 UTC
Type: ---
Embargoed:
wtogami: fedora-cvs+


Attachments (Terms of Use)

Description Christopher Stone 2006-10-29 22:52:58 UTC
Spec URL: http://tkmame.retrogames.com/fedora-extras/php-pear-HTTP-Request.spec
SRPM URL: http://tkmame.retrogames.com/fedora-extras/php-pear-HTTP-Request-1.4.0-1.src.rpm

Description:
Supports GET/POST/HEAD/TRACE/PUT/DELETE, Basic authentication, Proxy,
Proxy Authentication, SSL, file uploads etc.

Comment 1 Remi Collet 2006-11-05 18:32:02 UTC
* source files match upstream:
2aacf8ac8ce9aa865269f6b5e4c256b9  HTTP_Request-1.4.0.tgz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible (BSD).
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development).
* package installs properly
* rpmlint is silent.
* final provides are sane:
php-pear(HTTP_Request) = 1.4.0
php-pear-HTTP-Request = 1.4.0-1.fc7
* %check is not present; no test suite provide.
* owns the directories it creates (HTTP already owned but by non-dependant rpm)
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (pear install)
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

SHOULD requires other extensions with minimal version.
php-pear(Net_URL) >= 1.0.12
php-pear(Net_Socket) >= 1.0.2
php-pear(PEAR) >= 1.4.0b1

APPROVED

Comment 2 Christopher Stone 2006-11-08 00:59:30 UTC
Added versioned requires, thanks for the reviews.

Comment 3 Christopher Stone 2007-04-29 18:33:05 UTC
Package Change Request
======================
Package Name: php-pear-HTTP-Request
New Branches: EL-5


Note You need to log in before you can comment on or make changes to this bug.