Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 827008 (libkcddb) - Review Request: libkcddb - A KDE CDDB retrieval library
Summary: Review Request: libkcddb - A KDE CDDB retrieval library
Keywords:
Status: CLOSED RAWHIDE
Alias: libkcddb
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews kscd
TreeView+ depends on / blocked
 
Reported: 2012-05-31 12:16 UTC by Jaroslav Reznik
Modified: 2012-06-12 16:23 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-06-09 00:01:33 UTC
Type: ---
Embargoed:
rdieter: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Jaroslav Reznik 2012-05-31 12:16:44 UTC 
Spec URL: http://rezza.hofyland.cz/fedora/packages/kdemultimedia/libkcddb.spec
SRPM URL: http://rezza.hofyland.cz/fedora/packages/kdemultimedia/libkcddb-4.8.80-1.fc16.src.rpm
Description: A KDE CDDB retrieval library.
Fedora Account System Username: jreznik

http://koji.fedoraproject.org/koji/taskinfo?taskID=4116686

rpmlint libkcddb-4.8.80-1.fc16.x86_64.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

rpmlint libkcddb-4.8.80-1.fc16.src.rpm 
libkcddb.src: W: invalid-url Source0: ftp://ftp.kde.org/pub/kde/unstable/4.8.80/src/libkcddb-4.8.80.tar.xz <urlopen error ftp error: 550 Failed to change directory.>
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

(pre packages)
Comment 1 Rex Dieter 2012-05-31 19:41:34 UTC 
The only thing I see really is to fixup conflicts:

1.
Conflicts:  kdemultimedia-libs < 6:4.8.80-1 
and -devel:
Conflicts:  kdemultimedia-devel < 6:4.8.80-1


otherwise, the rest is a relatively simple library

naming: ok

sources: ok

licensing: ok

scriptlets: ok

macros: ok


APPROVED (item 1 can be done post review, prior to building)
Comment 2 Kevin Kofler 2012-05-31 20:02:28 UTC 
BuildRequires:  kdelibs-devel >= %{version}
is not going to work (missing Epoch), please use:
BuildRequires:  kdelibs4-devel >= %{version}
instead. (The virtual Provides has no Epoch, among other reasons.)
Comment 3 Jaroslav Reznik 2012-06-04 11:44:45 UTC 
Fixed

Spec URL: http://rezza.hofyland.cz/fedora/packages/kdemultimedia/libkcddb.spec
SRPM URL: http://rezza.hofyland.cz/fedora/packages/kdemultimedia/libkcddb-4.8.80-1.fc16.src.rpm
Comment 4 Jaroslav Reznik 2012-06-04 11:46:26 UTC 
New Package SCM Request
=======================
Package Name: libkcddb
Short Description: A KDE CDDB retrieval library
Owners: jreznik ltinkl rdieter than kkofler
Branches: f17
InitialCC:
Comment 5 Gwyn Ciesla 2012-06-04 12:08:55 UTC 
Git done (by process-git-requests).
Comment 6 Rex Dieter 2012-06-09 00:01:33 UTC 
imported
Note You need to log in before you can comment on or make changes to this bug.