Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 830362 (kscd) - Review Request: kscd - CD Player
Summary: Review Request: kscd - CD Player
Keywords:
Status: CLOSED RAWHIDE
Alias: kscd
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jaroslav Reznik
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: libkcddb libkcompactdisc audiocd-kio
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2012-06-09 00:42 UTC by Rex Dieter
Modified: 2012-06-20 16:42 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-06-20 16:42:22 UTC
Type: ---
Embargoed:
jreznik: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Rex Dieter 2012-06-09 00:42:03 UTC 
Spec URL: http://rdieter.fedorapeople.org/rpms/kdemm/kscd.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/kdemm/kscd-4.8.90-1.fc17.src.rpm
Description: CD Player
Fedora Account System Username: rdieter

New package from upstream splitting the once-monolithic kdemultimedia tarball (and why this one includes Obsoletes)
Comment 1 Rex Dieter 2012-06-14 18:43:34 UTC 
Spec URL: http://rdieter.fedorapeople.org/rpms/kdemm/kscd.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/kdemm/kscd-4.8.90-2.fc17.src.rpm

%changelog
* Wed Jun 13 2012 Rex Dieter <rdieter> 4.8.90-2
- +%%doc ChangeLog README TODO
Comment 2 Jaroslav Reznik 2012-06-19 16:26:29 UTC 
Name: ok
Summary: ok
License: ok, GPLv2+
URL: I'd use this one http://www.kde.org/applications/multimedia/kscd/ (more user friendly)
Sources: ok (md5sum fd334bf6dec27e8b6706e196638a2bef)
BuildRequires: ok
Requires: ok
Obsoletes/Provides: ok, kdemultimedia-kscd split
Description: ok (maybe more descriptive "KsCD is a small, fast, CDDB enabled audio CD player.")
Build: ok
Macros used consistently: ok
Desktop file validation: ok
Icon cache update: ok
Docs: ok

rpmlint kscd-4.8.90-2.fc17.src.rpm 
kscd.src:53: W: macro-in-comment %{name}
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

#find_lang %{name} --with-kde --all-name
are translations in kde-l10n or not?
Comment 3 Rex Dieter 2012-06-19 16:49:09 UTC 
the find_lang call here are used to pick up the khelpcenter handbooks, but kscd doesn't have one.  I probably should've just removed it, rather than comment it out
Comment 4 Rex Dieter 2012-06-19 16:49:42 UTC 
But otherwise, yes, gettext translations are in kde-l10n (or should be)
Comment 5 Rex Dieter 2012-06-19 17:38:33 UTC 
Spec URL: http://rdieter.fedorapeople.org/rpms/kdemm/kscd.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/kdemm/kscd-4.8.90-3.fc17.src.rpm

%changelog
* Tue Jun 19 2012 Rex Dieter <rdieter> 4.8.90-3
- update URL, %%description
Comment 6 Jaroslav Reznik 2012-06-20 14:27:27 UTC 
Thanks Rex,
APPROVED.
Comment 7 Rex Dieter 2012-06-20 15:12:40 UTC 
thanks.

New Package SCM Request
=======================
Package Name: kscd
Short Description: CD player
Owners: than,rdieter,jreznik,rnovacek,ltinkl,kkofler
Branches: f17
InitialCC:
Comment 8 Gwyn Ciesla 2012-06-20 15:16:02 UTC 
Git done (by process-git-requests).
Comment 9 Rex Dieter 2012-06-20 16:42:22 UTC 
imported
Note You need to log in before you can comment on or make changes to this bug.