Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 830360 (audiocd-kio) - Review Request: audiocd-kio - Audiocd kio slave
Summary: Review Request: audiocd-kio - Audiocd kio slave
Keywords:
Status: CLOSED RAWHIDE
Alias: audiocd-kio
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jaroslav Reznik
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews kscd
TreeView+ depends on / blocked
 
Reported: 2012-06-09 00:03 UTC by Rex Dieter
Modified: 2012-06-14 19:16 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-06-14 19:16:40 UTC
Type: ---
Embargoed:
jreznik: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Rex Dieter 2012-06-09 00:03:32 UTC 
Spec URL: http://rdieter.fedorapeople.org/rpms/kdemm/audiocd-kio.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/kdemm/audiocd-kio-4.8.90-1.fc17.src.rpm
Description: Audiocd kio slave
Fedora Account System Username: rdieter


New package from upstream splitting the once-monolithic kdemultimedia tarball (and why this one includes Obsoletes)
Comment 1 Jaroslav Reznik 2012-06-13 10:59:43 UTC 
Name: ok (match upstream, kio_audiocd provided)
Summary: ok
License: not ok, GPLv2+ and GFDL for documentation

./kcmaudiocd/kcmaudiocd.h: GPL (v2 or later) (with Qt exception) 

URL: ok
Sources: ok (md5sum a3ce8cc1ebd98ac3b853ccecda79dbbe)
BuildRequires: ok (libkcddb and libkcompactdisc already imported to Fedora)
Requires: ok
Obsoletes/provides: ok, kdemultimedia-kio_audiocd split. Provides kio_audiocd to match the rest of KIO slaves
Description: ok
-libs subpackage: ok, conflicts ok (kdemultimedia-libs), ldconfig ok
Build: ok
Docs: ok

rpmlint audiocd-kio-4.8.90-1.fc17.src.rpm 
audiocd-kio.src: W: invalid-url Source0: http://download.kde.org/unstable/4.8.90/src/audiocd-kio-4.8.90.tar.xz HTTP Error 403: Forbidden
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

4.8.90 is still private.

It's a split package, looks good, pls fix license and I'll approve this one.
Comment 2 Rex Dieter 2012-06-13 13:34:29 UTC 
Spec URL: http://rdieter.fedorapeople.org/rpms/kdemm/audiocd-kio.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/kdemm/audiocd-kio-4.8.90-2.fc17.src.rpm

%changelog
* Wed Jun 13 2012 Rex Dieter <rdieter> 4.8.90-2
- License: GPLv2+ and GFDL
Comment 3 Jaroslav Reznik 2012-06-13 14:30:36 UTC 
Thanks Rex,
APPROVED.
Comment 4 Rex Dieter 2012-06-13 14:35:57 UTC 
New Package SCM Request
=======================
Package Name: audiocd-kio
Short Description: Audiocd kio slave
Owners: than,rdieter,jreznik,rnovacek,ltinkl,kkofler
Branches: f17
InitialCC:
Comment 5 Gwyn Ciesla 2012-06-13 14:44:50 UTC 
Git done (by process-git-requests).
Comment 6 Rex Dieter 2012-06-14 19:16:40 UTC 
imported
Note You need to log in before you can comment on or make changes to this bug.