Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 829393 (libkcompactdisc) - Review Request: libkcompactdisc - A KDE compact disc library
Summary: Review Request: libkcompactdisc - A KDE compact disc library
Keywords:
Status: CLOSED RAWHIDE
Alias: libkcompactdisc
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Lukáš Tinkl
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews kscd
TreeView+ depends on / blocked
 
Reported: 2012-06-06 15:15 UTC by Jaroslav Reznik
Modified: 2015-07-13 17:36 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-06-09 00:01:44 UTC
Type: ---
Embargoed:
ltinkl: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Jaroslav Reznik 2012-06-06 15:15:53 UTC 
Spec URL: http://rezza.hofyland.cz/fedora/packages/kdemultimedia/libkcompactdisc.spec
SRPM URL: http://rezza.hofyland.cz/fedora/packages/kdemultimedia/libkcompactdisc-4.8.80-1.fc16.src.rpm
Description: A KDE compact disc library.
Fedora Account System Username: jreznik

http://koji.fedoraproject.org/koji/taskinfo?taskID=4132730

rpmlint libkcompactdisc-4.8.80-1.fc16.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Comment 1 Lukáš Tinkl 2012-06-06 15:30:42 UTC 
[ltinkl@goblin libkcd]$ rpmlint libkcompactdisc.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

[ltinkl@goblin libkcd]$ rpmlint libkcompactdisc-4.8.80-1.fc16.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

It would be nice to package at least COPYING and wmlib/README files as doc
Comment 2 Jaroslav Reznik 2012-06-07 11:47:32 UTC 
Ops, sorry, old version. After respin (which finally contains COPYING) I forgot to update SPEC too...
Comment 3 Jaroslav Reznik 2012-06-07 11:57:21 UTC 
Correct SPEC uploaded, SRPM contained the right one but reuploaded too to be sure.
Comment 4 Lukáš Tinkl 2012-06-07 12:32:01 UTC 
Looks good now, good to submit
Comment 5 Lukáš Tinkl 2012-06-07 14:33:12 UTC 
Name: ok
Summary: ok
License: ok
URL: ok (part of kdemultimedia)
Source: ok
BRs: ok
Conflicts: ok
Description: ok
Macro consistency: ok
Desktop file validation: ok
Lang. packaged: ok
Docs: ok (corrected after 1st try)
Legal: ok

The package is ok from the kde/qt packaging view. Already packaged in Fedora, this is a split of previously monolithic kdemultimedia package.
Comment 6 Jaroslav Reznik 2012-06-07 14:45:05 UTC 
New Package SCM Request
=======================
Package Name: libkcompactdisc
Short Description: A KDE compact disc library.
Owners: jreznik than ltinkl rdieter kkofler rnovacek
Branches: f17
InitialCC:
Comment 7 Gwyn Ciesla 2012-06-07 15:10:12 UTC 
Git done (by process-git-requests).
Comment 8 Rex Dieter 2012-06-09 00:01:44 UTC 
imported
Note You need to log in before you can comment on or make changes to this bug.