Review of globus-gridftp-server-control:

koji build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1746671


MUST:

no: 
$ rpmlint globus-gridftp-server-control.spec ../SRPMS/globus-gridftp-server-control-0.36-1.fc11.src.rpm ../RPMS/x86_64/globus-gridftp-server-control-*
globus-gridftp-server-control-debuginfo.x86_64: E: description-line-too-long This package provides debug information for package globus-gridftp-server-control.
globus-gridftp-server-control-devel.x86_64: W: no-documentation
4 packages and 1 specfiles checked; 1 errors, 1 warnings.

which is fine 
yes: Package name - globus guidelines
yes: Spec File name - globus guidelines
yes: Packaging guidelines
yes: Apache 2.0
yes: .spec ASL 2.0
yes: GLOBUS_LICENSE included.
yes: american english.
yes: Upstream source matches.
$ diff -r --brief gt4.2.1-all-source-installer/source-trees/gridftp/server-lib/src ~/rpmbuild/SOURCES/globus_gridftp_server_control-0.36
Only in /home/steve/rpmbuild/SOURCES/globus_gridftp_server_control-0.36: GLOBUS_LICENSE


which is expected.

yes: builds as per koji build above.
yes: locales not present.
yes: Calls ldconfig appropriate
yes: No system libs included.
yes: not relocatable.
yes: All files and directories created in the package are owned.
yes: files not listed twice.
yes: defattr used everywhere.
yes: Buildroot is removed in %clean.
yes: consistant macros
yes: no large docs.
yes: docs not needed runtime.
yes: headers in -devel file.
yes: libs correctly in -devel package.
yes: main package is needed by devel package.
yes: no .la files present.
yes: no gui.
yes: does not own files belonging to other packages.
yes: buildroot removed in %install.
yes: utf8

APPROVED

Sorry not approved, auto pilot.

The summary line is a little long which I realise is the fact that
the package is name is so long.

Steve

(In reply to comment #2)
> Sorry not approved, auto pilot.
> 
> The summary line is a little long which I realise is the fact that
> the package is name is so long.
> 
> Steve  

The only package for which rpmlint complains about the length of the description line is the debuginfo package. The definition of the description of the debuginfo package is not part if the specfile, but is defined in the %debug_info macro. Any package that has a name longer that 27 characters will trip on this.

[ellert@ellert ~]$ rpm -E %debug_package

%ifnarch noarch
%package debuginfo 
Summary: Debug information for package %{name}
Group: Development/Debug
AutoReqProv: 0
%description debuginfo
This package provides debug information for package %{name}.
Debug information is useful when developing applications that use this
package or when debugging this package.
%files debuginfo -f debugfiles.list
%defattr(-,root,root)
%endif

I can't do much about this except redefining the macro, which I find to be an overkill.

When I first saw this rpmlint error I checked what other packages had done. There are many packages in Fedora with names longer than 27 characters. The current practice seems to be to ignore this error for debuginfo packages. (See bug 525304, bug 523326, bug 516516, bug 498189, bug 496429 and others.)

Sorry, I did not intend to reference back to this bug (516516) - that was a C&P error.

Could we at least submit a bug on the macro. It could be changed more
generally I say to perhaps always word wrap at the desired length.

Steve

APPROVED

(In reply to comment #5)
> Could we at least submit a bug on the macro. It could be changed more
> generally I say to perhaps always word wrap at the desired length.

Such a bug report already exists: see bug 484616.
(It was already submitted by someone else.)(In reply to comment #5)

New Package CVS Request
=======================
Package Name: globus-gridftp-server-control
Short Description: Globus Toolkit - Globus GridFTP Server Library
Owners: ellert
Branches: F-11 F-12 EL-4 EL-5
InitialCC:

cvs done.

globus-gridftp-server-control-0.36-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/globus-gridftp-server-control-0.36-1.fc12

globus-gridftp-server-control-0.36-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/globus-gridftp-server-control-0.36-1.fc11

globus-gridftp-server-control-0.36-1.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/globus-gridftp-server-control-0.36-1.el5

globus-gridftp-server-control-0.36-1.el4 has been submitted as an update for Fedora EPEL 4.
http://admin.fedoraproject.org/updates/globus-gridftp-server-control-0.36-1.el4

globus-gridftp-server-control-0.36-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

globus-gridftp-server-control-0.36-1.el4 has been pushed to the Fedora EPEL 4 stable repository.  If problems still persist, please make note of it in this bug report.

globus-gridftp-server-control-0.36-1.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.