Bug 785432 (Horde_Translation)

First note:

According to upstream (see package.xml), this requires
php-common >= 5.2.0
php-pear(PEAR) >= 1.7.0
php-pear(pear.horde.org/Horde_Test) >= 1.0.0
php-pear(pear.horde.org/Horde_Test) < 2.0.0

%file must be fixed (as explain in the generated spec)

%{pear_xmldir}/%{name}.xml
%{pear_phpdir}/Horde/Translation
%{pear_phpdir}/Horde/Translation.php
%{pear_testdir}/Horde_Translation
%{pear_phpdir}/Horde will be owned by dependant package (Horde_Test, I think)

A good idea will be to create a macro for the channel and to use it.  Also verify that the pear_name is used everywhere it could.

It seems Horde_Test is not in the review list.

Can you please try to run provided tests in %check (else add a comment/explanation on the reason)

Well... reading the stack dependency

Horde-Test => Horde_Util => Horde_Url => Horde_Exception => Horde_Translation

So cannot BR horde-test... :(

So cannot run test in mock.

Horde_Test is in the review list now.  I haven't made it a requirement for this since the dependency circle, but it's listed as an optional dep in the package.xml.

Updated.

=== FORMAL REVIEW ===
 -=N/A  x=Check  !=Problem,  ?=Not evaluated

=== REQUIRED ITEMS ===
 [x] Rpmlint output:
php-horde-Horde-Translation.noarch: W: no-documentation
 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
 [x] Package meets the Packaging Guidelines including the PHP specific items
 [x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
     License type: LGPLv2+
 [x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
	md5sum : 4d67b9709ead5bafe095bda5688bc76f  /tmp/Horde_Translation-1.0.1.tgz
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested on: f16
 [-] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
 [x] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [-] Packages don't bundle copies of system librarie
 [-] Package is not relocatable.
 [!] Package must own all directories that it creates.
 [!] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [-] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -static subpackage, if present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages with %{?_isa}, if present.
 [-] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
 [-] All filenames in rpm packages must be valid UTF-8
 [-] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS ===
 [x] Final requires
php-channel(pear.horde.org)  
php-common >= 5.2.0
php-pear(pear.horde.org/Horde_Test) >= 1.0.0
php-pear(pear.horde.org/Horde_Test) < 2.0.0
 [x] Final provides
php-pear(pear.horde.org/Horde_Translation) = 1.0.1
php-horde-Horde-Translation = 1.0.1-1.fc16
 [x] Latest version is packaged.
 [!] If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it. 
 [-] The description and summary sections in the package spec file should contain
     translations for supported Non-English languages, if available.
 [?] Reviewer should test that the package builds in mock.
     Tested on: Koji 
 [-] The package should compile and build into binary rpms on all supported architectures.
     Tested on: 
 [?] Package functions as described.
 [x] If scriptlets are used, those scriptlets must be sane. 
 [-] If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin 
     consider requiring the package which provides the file instead of the file itself. 
 [-] your package should contain man pages for binaries/scripts. 
     If it doesn't, work with upstream to add them where they make sense.
 [-] The placement of pkgconfig(.pc) files is correct.
 [?] %check is present and the tests pass

SHOULD: 
Please ask upstream to include LICENSE file

I agree with you comment #3, Horde_Test is only a optional dependency, so I was surprise to see you add it...
As Horde_Test will pull a lot of dependencies (among them: PHPUnit and xdebug, which are dev tool, not really usefull on a server), I think you could remove this.

I let you the choice.

MUST: 
- which package will own /usr/share/pear/Horde ?

This package (the first of the stack, without other dependency, except Horde_Test, if you keep it) seems a good candidate.

Of course, I have miss the
warning: File listed twice: /usr/share/pear/test/Horde_Translation/Horde/Translation/locale/de/LC_MESSAGES/Horde_Other.mo
warning: File listed twice: /usr/share/pear/test/Horde_Translation/Horde/Translation/locale/de/LC_MESSAGES/Horde_Translation.mo

Updated.  I've fixed everything except for us figuring out what to do about the lang files.

This package now owns /usr/share/pear/Horde also

Remi, this one is updated also.

MUST: Package must own all directories that it creates.

Unowned directories

/usr/share/pear/Horde
/usr/share/pear/test/Horde_Translation/Horde
/usr/share/pear/test/Horde_Translation/Horde/Translation
/usr/share/pear/test/Horde_Translation/Horde/Translation/locale
/usr/share/pear/test/Horde_Translation/Horde/Translation/locale/de
/usr/share/pear/test/Horde_Translation/Horde/Translation/locale/de/LC_MESSAGES

I added those now.

All MUST fixed

APPROVED

Sorry, I miss that one

Please remove Horde_Test (optional) requirement which is not yet available.

Done

New Package SCM Request
=======================
Package Name: php-horde-Horde-Translation
Short Description: Translation wrappers for Horde
Owners: nb
Branches: f16 el6
InitialCC:

New Package SCM Request
=======================
Package Name: php-horde-Horde-Translation
Short Description: Translation wrappers for Horde
Owners: nb
Branches: f16 f17 el6
InitialCC:

Git done (by process-git-requests).